omit OneAsymmetricKey.publicKey field #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvangeest
reviewed
Oct 23, 2024
| the raw octet string encoding of the 64-octet seed. | ||
| the raw octet string encoding of the 64-octet seed. The publicKey field | ||
| SHOULD be omitted because the public key can be compute as noted earlier | ||
| in this section. | ||
|
|
||
| <aside markdown="block"> |
There was a problem hiding this comment.
IMO, now that the public key friend is recommended to be omitted, this NOTE isn't needed anymore.
danvangeest
reviewed
Oct 23, 2024
bwesterb
approved these changes
Oct 23, 2024
bwesterb
reviewed
Oct 23, 2024
| @@ -279,7 +279,9 @@ algorithm itself. | |||
| </aside> | |||
|
|
|||
| When used in a OneAsymmetricKey type, the privateKey OCTET STRING contains | |||
| the raw octet string encoding of the 64-octet seed. | |||
| the raw octet string encoding of the 64-octet seed. The publicKey field | |||
| SHOULD be omitted because the public key can be compute as noted earlier | |||
There was a problem hiding this comment.
Typo: "computed". I'd phrase it like "because the public key is computed as part of using the private key".
seanturner
commented
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.