-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use seed as private key #58
Conversation
bwesterb
commented
Oct 21, 2024
•
edited
Loading
edited
- Add text that we use seed as private key
- Add examples for all three parameter sets.
- Deduplicate.
I can decode the .pub examples, but none of the .priv examples. I am getting "Length over 48 bits not supported at position 1." |
12bf9be
to
f0b8e93
Compare
Not sure what issue you hit, but I updated the examples because I noticed I didn't replace the private key by the seed yet 😬. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can decode these just fine. Will add the ASN.1 pretty prints via another PR.
Will look to do a Certificate we get the ML-DSA I-D closer to done.
An ML-KEM private key is encoded by storing its 64-octet seed in | ||
the privateKey field as follows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with using the 64-byte seed, but technically, a FIPS 203-compliant ML-KEM private key is / can be either a 64-byte seed or the fully expanded decapsulation key format; in this phrase, what is the meaning of 'is'? The ML-KEM in use in this document? Or the ML-KEM in FIPS 203? (Making this harmonious with the next paragraph would help)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking this sentence could be removed from the standard. It's here as a stepping stone to the precise definition. We could add a marker like "essentially" or "in short".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, went with 'in short': #68