Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add No Signature Example for KEM certificate #55

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

seanturner
Copy link
Collaborator

Adding an example to 5272 Appendix B that shows the No Signature mechanism for KEM key.

Adding an example to 5272 Appendix B that shows the No Signature mechanism for KEM key.
@seanturner seanturner requested a review from mandelj7 as a code owner July 24, 2024 16:52
@seanturner
Copy link
Collaborator Author

@ounsworth @johngray-dev @HBrock PTAL. Note that we will also need to add some text in -rfc5273bis; see #38.

@seanturner
Copy link
Collaborator Author

Will tweak this via a later PR to address erratum 8027.

@seanturner
Copy link
Collaborator Author

@carl-wallace PTAL

@carl-wallace
Copy link

Two comments:

  1. id-ct-PKIData should be id-cct-PKIData, as defined in Section 3.2.1. This is noted in https://www.rfc-editor.org/errata/eid4775 as being a pervasive issue.
  2. The first client to server message example should include subjectKeyIdentifier extension to satisfy 3.2.a.

@mandelj7 mandelj7 merged commit a627b2d into main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants