Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata related patches #136

Merged
merged 3 commits into from Nov 28, 2023
Merged

Appdata related patches #136

merged 3 commits into from Nov 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2023

appdata: Use appstreamcli for appdata validation

appstream-util is obsoleted by appstreamcli.

appdata: Add categories, keywords and launchable tags

These tags may improve Software Center accessibility.

More information: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-categories

po: Update the POT file

Add new strings.

appstream-util is obsoleted by appstreamcli.
Add new strings.
@ghost ghost changed the title Appstream related patches Appdata related patches Oct 29, 2023
@ghost
Copy link
Author

ghost commented Oct 29, 2023

Michael Catanzaro recommended the use of appstreamcli in this comment.

@ghost
Copy link
Author

ghost commented Nov 11, 2023

@lainsce Ready to be reviewed. It failed but IMHO it's not related to my changes.

flatpak-builder build-dir --ccache --force-clean --user --install io.github.lainsce.Khronos.Devel.json 
Downloading sources
Initializing build dir
Committing stage init to cache
Starting build of io.github.lainsce.Khronos.Devel
========================================================================
Building module khronos in /home/sabri/C/DEV/GNOME/Circle/Classic/khronos/.flatpak-builder/build/khronos-1
========================================================================
The Meson build system
Version: 1.2.3
Source dir: /run/build/khronos
Build dir: /run/build/khronos/_flatpak_build
Build type: native build
Project name: io.github.lainsce.Khronos
Project version: 4.0.0
C compiler for the host machine: ccache cc (gcc 13.2.0 "cc (GCC) 13.2.0")
C linker for the host machine: cc ld.bfd 2.41
Vala compiler for the host machine: valac (valac 0.57.0.214-f25d)
Host machine cpu family: x86_64
Host machine cpu: x86_64
Configuring config.h using configuration
Found pkg-config: /usr/bin/pkg-config (2.0.2)
Build-time dependency gio-2.0 found: YES 2.79.0
Program /usr/bin/glib-compile-resources found: YES (/usr/bin/glib-compile-resources)
Dependency gio-2.0 found: YES 2.79.0 (cached)
Found pkg-config: /usr/bin/pkg-config (2.0.2)
Run-time dependency gtk4 found: YES 4.13.3
Run-time dependency glib-2.0 found: YES 2.79.0
Run-time dependency gobject-2.0 found: YES 2.79.0
Run-time dependency gee-0.8 found: YES 0.20.6
Run-time dependency libadwaita-1 found: YES 1.5.alpha
Run-time dependency json-glib-1.0 found: YES 1.8.1
Library m found: YES
Configuring io.github.lainsce.Khronos.Devel.desktop.in using configuration
Program msgfmt found: YES (/usr/bin/msgfmt)
Program desktop-file-validate found: YES (/usr/bin/desktop-file-validate)
Configuring io.github.lainsce.Khronos.Devel.metainfo.xml.in using configuration
Program appstreamcli found: YES (/usr/bin/appstreamcli)
Dependency gio-2.0 found: YES 2.79.0 (cached)
Program /usr/bin/glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Program msginit found: YES (/usr/bin/msginit)
Program msgmerge found: YES (/usr/bin/msgmerge)
Program xgettext found: YES (/usr/bin/xgettext)
Dependency gio-2.0 found: YES 2.79.0 (cached)
Program /usr/bin/glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Program gtk4-update-icon-cache found: YES (/usr/bin/gtk4-update-icon-cache)
Program update-desktop-database found: YES (/usr/bin/update-desktop-database)
Build targets in project: 31

io.github.lainsce.Khronos 4.0.0

  User defined options
    prefix     : /app
    development: true

Found ninja-1.11.1 at /usr/bin/ninja
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
[29/47] Compiling Vala source ../src/Application.vala ../src/MainWindow.vala ../src/Models/...../src/Services/Dialog.vala ../src/Widgets/LogRowContent.vala ../src/Widgets/TagHolder.vala
../src/Utils/ThreadUtils.vala:40:13-40:95: warning: unhandled error `GLib.ThreadError'
   40 |             var tp = new ThreadPool<Worker>.with_owned_data (worker => worker.run (), 1, false);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../src/Services/Dialog.vala:20:27-20:47: warning: `Gtk.FileChooserNative' has been deprecated since 4.10
   20 |         var chooser = new Gtk.FileChooserNative (null, win, Gtk.FileChooserAction.SAVE, null, null);
      |                           ^~~~~~~~~~~~~~~~~~~~~                                                     
../src/Services/Dialog.vala:20:13-20:19: warning: `Gtk.FileChooserNative' has been deprecated since 4.10
   20 |         var chooser = new Gtk.FileChooserNative (null, win, Gtk.FileChooserAction.SAVE, null, null);
      |             ^~~~~~~                                                                                 
../src/Services/Dialog.vala:61:54-61:81: warning: `Gtk.FileChooserNative' has been deprecated since 4.10
   61 |     private async Gtk.ResponseType run_dialog_async (Gtk.FileChooserNative dialog) {
      |                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~   
../src/Services/Dialog.vala:41:27-41:47: warning: `Gtk.FileChooserNative' has been deprecated since 4.10
   41 |         var chooser = new Gtk.FileChooserNative (null, win, Gtk.FileChooserAction.OPEN, null, null);
      |                           ^~~~~~~~~~~~~~~~~~~~~                                                     
../src/Services/Dialog.vala:41:13-41:19: warning: `Gtk.FileChooserNative' has been deprecated since 4.10
   41 |         var chooser = new Gtk.FileChooserNative (null, win, Gtk.FileChooserAction.OPEN, null, null);
      |             ^~~~~~~                                                                                 
Compilation succeeded - 6 warning(s)
[47/47] Linking target io.github.lainsce.Khronos
[0/1] Installing files.
Installing subdir /run/build/khronos/data/icons/hicolor/scalable to /app/share/icons/hicolor/scalable
Installing /run/build/khronos/data/icons/hicolor/scalable/actions/stopwatch-symbolic.svg to /app/share/icons/hicolor/scalable/actions
Installing subdir /run/build/khronos/data/icons/hicolor/symbolic to /app/share/icons/hicolor/symbolic
Installing /run/build/khronos/data/icons/hicolor/symbolic/clock-alt-symbolic.svg to /app/share/icons/hicolor/symbolic
Installing io.github.lainsce.Khronos to /app/bin
Installing data/io.github.lainsce.Khronos.Devel.desktop to /app/share/applications
Installing data/io.github.lainsce.Khronos.Devel.metainfo.xml to /app/share/metainfo
Installing po/ca/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/ca/LC_MESSAGES
Installing po/cs/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/cs/LC_MESSAGES
Installing po/da/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/da/LC_MESSAGES
Installing po/de/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/de/LC_MESSAGES
Installing po/es/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/es/LC_MESSAGES
Installing po/fr/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/fr/LC_MESSAGES
Installing po/he/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/he/LC_MESSAGES
Installing po/hr/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/hr/LC_MESSAGES
Installing po/id/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/id/LC_MESSAGES
Installing po/it/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/it/LC_MESSAGES
Installing po/ja/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/ja/LC_MESSAGES
Installing po/lt/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/lt/LC_MESSAGES
Installing po/nl/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/nl/LC_MESSAGES
Installing po/pt/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/pt/LC_MESSAGES
Installing po/pt_BR/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/pt_BR/LC_MESSAGES
Installing po/ru_RU/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/ru_RU/LC_MESSAGES
Installing po/sk/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/sk/LC_MESSAGES
Installing po/sr/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/sr/LC_MESSAGES
Installing po/sr@latin/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/sr@latin/LC_MESSAGES
Installing po/sv/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/sv/LC_MESSAGES
Installing po/tr/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/tr/LC_MESSAGES
Installing po/zh_CN/LC_MESSAGES/io.github.lainsce.Khronos.Devel.mo to /app/share/locale/zh_CN/LC_MESSAGES
Installing /run/build/khronos/data/io.github.lainsce.Khronos.gschema.xml to /app/share/glib-2.0/schemas
Installing /run/build/khronos/data/icons/io.github.lainsce.Khronos.Devel.svg to /app/share/icons/hicolor/scalable/apps
Installing /run/build/khronos/data/icons/io.github.lainsce.Khronos-symbolic.svg to /app/share/icons/hicolor/symbolic/apps
Running custom install script '/usr/bin/glib-compile-schemas /app/share/glib-2.0/schemas'
Running custom install script '/usr/bin/gtk4-update-icon-cache -q -t -f /app/share/icons/hicolor'
Running custom install script '/usr/bin/update-desktop-database -q /app/share/applications'
compressing debuginfo in: /home/sabri/C/DEV/GNOME/Circle/Classic/khronos/.flatpak-builder/rofiles/rofiles-hdJm3v/files/bin/io.github.lainsce.Khronos
processing: /home/sabri/C/DEV/GNOME/Circle/Classic/khronos/.flatpak-builder/rofiles/rofiles-hdJm3v/files/bin/io.github.lainsce.Khronos
[31] .debug_aranges compressed -> .zdebug_aranges (1152 => 328 28.47%)
[32] .debug_info compressed -> .zdebug_info (267339 => 132443 49.54%)
[33] .debug_abbrev compressed -> .zdebug_abbrev (24302 => 5817 23.94%)
[34] .debug_line compressed -> .zdebug_line (84774 => 29302 34.56%)
[35] .debug_str compressed -> .zdebug_str (50984 => 13302 26.09%)
[36] .debug_line_str compressed -> .zdebug_line_str (3621 => 1150 31.76%)
[37] .debug_loclists compressed -> .zdebug_loclists (70761 => 29700 41.97%)
[38] .debug_rnglists compressed -> .zdebug_rnglists (7410 => 5049 68.14%)
[41] Updating section string table
stripping /home/sabri/C/DEV/GNOME/Circle/Classic/khronos/.flatpak-builder/rofiles/rofiles-hdJm3v/files/bin/io.github.lainsce.Khronos to /home/sabri/C/DEV/GNOME/Circle/Classic/khronos/.flatpak-builder/rofiles/rofiles-hdJm3v/files/lib/debug/bin/io.github.lainsce.Khronos.debug
Committing stage build-khronos to cache
Cleaning up
Renaming io.github.lainsce.Khronos.Devel.metainfo.xml to share/appdata/io.github.lainsce.Khronos.Devel.appdata.xml
Rewriting contents of io.github.lainsce.Khronos.Devel.desktop
Running appstream-compose
Processing application io.github.lainsce.Khronos.Devel
Saving AppStream /app/share/app-info/xmls/io.github.lainsce.Khronos.Devel.xml.gz
Done!
Committing stage cleanup to cache
Finishing app
Not exporting share/applications/mimeinfo.cache, wrong extension
Exporting share/applications/io.github.lainsce.Khronos.Devel.desktop
Not exporting share/icons/hicolor/symbolic/clock-alt-symbolic.svg, non-allowed export filename
Exporting share/icons/hicolor/symbolic/apps/io.github.lainsce.Khronos.Devel-symbolic.svg
Not exporting share/icons/hicolor/icon-theme.cache, wrong extension
Not exporting share/icons/hicolor/scalable/actions/stopwatch-symbolic.svg, non-allowed export filename
Exporting share/icons/hicolor/scalable/apps/io.github.lainsce.Khronos.Devel.svg
Exporting share/appdata/io.github.lainsce.Khronos.Devel.appdata.xml
Please review the exported files and the metadata
Committing stage finish to cache
Exporting io.github.lainsce.Khronos.Devel to repo
Commit: 6062be496768b1cc6a2c7c11895edb89da56f144ee95a24c3b0ca0c90764add4
Metadata Total: 107
Metadata Written: 7
Content Total: 40
Content Written: 0
Content Bytes Written: 0 (0 bytes)
Exporting io.github.lainsce.Khronos.Devel.Locale to repo
Commit: d9bca0c9d1b318c8fcd9252b96342cd7bc99874c51535125c2efa7a17e2f9687
Metadata Total: 173
Metadata Written: 2
Content Total: 23
Content Written: 0
Content Bytes Written: 0 (0 bytes)
Exporting io.github.lainsce.Khronos.Devel.Debug to repo
Commit: a5264012fdf628eac43e0431e0148a2474968070c5a4d8c5298f231393bc08f5
Metadata Total: 47
Metadata Written: 2
Content Total: 37
Content Written: 0
Content Bytes Written: 0 (0 bytes)
Installing runtime/io.github.lainsce.Khronos.Devel.Locale/x86_64/master
Installing app/io.github.lainsce.Khronos.Devel/x86_64/master
Pruning cache

@lainsce
Copy link
Owner

lainsce commented Nov 28, 2023

Thanks for your help :3

@lainsce lainsce merged commit a76bd4a into lainsce:main Nov 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants