Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated URL in Resource Groups v2 command help text #1677

Merged
merged 13 commits into from
Nov 13, 2024

Conversation

ggaetz-fortinet
Copy link
Collaborator

Summary

Corrected URL in help text to point to public API documentation.

@ggaetz-fortinet ggaetz-fortinet requested a review from a team as a code owner November 4, 2024 21:22
@ggaetz-fortinet ggaetz-fortinet requested review from goodmorninggoaway, jeffreynglw and aclacework and removed request for a team November 4, 2024 21:22
@goodmorninggoaway
Copy link

@ggaetz-fortinet If you're waiting on reviews, post the PR in https://lacework.slack.com/archives/C05UD0RH6GJ

@ggaetz-fortinet
Copy link
Collaborator Author

I don't have access to Lacework Slack.

@goodmorninggoaway
Copy link

I don't have access to Lacework Slack.

That explains why I couldn't find you. You can request access via global helpdesk

@PengyuanZhao
Copy link
Contributor

@ggaetz-fortinet please change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/. In that way, your commit will be picked up and shown in the release notes.

@sushmadittakavilacework

@ggaetz-fortinet please change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/. In that way, your commit will be picked up and shown in the release notes.

Nice to see the commitmessage lint failure to catch this.

Copy link

@sushmadittakavilacework sushmadittakavilacework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint failure. The fix looks good to me.

@ggaetz-fortinet
Copy link
Collaborator Author

I fixed the commit message lint error but I'm not sure if or how to fix the lint error due to the long URL.

@sushmadittakavilacework

I fixed the commit message lint error but I'm not sure if or how to fix the lint error due to the long URL.

I dont know why there is a character limit. Does it need to be broken into two lines..? @PengyuanZhao do you know?

@PengyuanZhao
Copy link
Contributor

Yes, it would need to break into two lines. If using vscode, the Go plugin should be installed. It will automatically give hints and format the code.

@ggaetz-fortinet
Copy link
Collaborator Author

I fixed the linting errors so now it should be good, as long as the integration tests are ok.

Thanks for your patience.

@ggaetz-fortinet ggaetz-fortinet merged commit e610518 into main Nov 13, 2024
13 checks passed
@ggaetz-fortinet ggaetz-fortinet deleted the ggaetz_CLI_docs_update branch November 13, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants