-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated URL in Resource Groups v2 command help text #1677
Conversation
…ct documentation.
@ggaetz-fortinet If you're waiting on reviews, post the PR in https://lacework.slack.com/archives/C05UD0RH6GJ |
I don't have access to Lacework Slack. |
That explains why I couldn't find you. You can request access via global helpdesk |
@ggaetz-fortinet please change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/. In that way, your commit will be picked up and shown in the release notes. |
Nice to see the commitmessage lint failure to catch this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint failure. The fix looks good to me.
…blic documentation.
…nto ggaetz_CLI_docs_update
…ublic documentation.
I fixed the commit message lint error but I'm not sure if or how to fix the lint error due to the long URL. |
…ublic documentation.
…ublic documentation
…ublic documentation
I dont know why there is a character limit. Does it need to be broken into two lines..? @PengyuanZhao do you know? |
Yes, it would need to break into two lines. If using vscode, the |
…ublic documentation
I fixed the linting errors so now it should be good, as long as the integration tests are ok. Thanks for your patience. |
Summary
Corrected URL in help text to point to public API documentation.