(de)serialize values for refresh tokens #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvantellingen
requested changes
Feb 21, 2024
| @@ -27,7 +27,7 @@ export class FederatedAuthPlugin<TContext extends FederatedTokenContext> | |||
|
|
|||
| const rt = request.http?.headers.get("X-Refresh-Token"); | |||
| if (rt) { | |||
| contextValue.federatedToken.loadRefreshToken(rt); | |||
| contextValue.federatedToken.deserializeRefreshToken(rt); | |||
There was a problem hiding this comment.
the loadRefreshToken was chosen since it 'loads' it, i would expect a deserializeRefreshToken() to just return the value
|
Perhaps also good to outline in the PR description what this PR fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a federated token that contains values, the values got lost after refreshing.
This was especially a problem in systems that use values for specific logic.
For instance, using anonymous queries or authenticated queries based on an
anonymousvalue.The access token might be created for an authenticated user, but then after the refresh, the system thought it would be an anonymous token because the value was lost.