Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customer): add lowercaseEmail support #252

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mikedebock
Copy link
Member

Add support for querying a customer with lowercaseEmail.

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 615b4e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@labdigital/commercetools-mock Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@demeyerthom demeyerthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvantellingen mvantellingen self-requested a review November 21, 2024 07:16
Copy link
Member

@mvantellingen mvantellingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle email updates?

@mikedebock
Copy link
Member Author

How do we handle email updates?

Good catch! I also added that scenario now as well.

@mvantellingen mvantellingen merged commit de67c5f into main Nov 21, 2024
11 checks passed
@mvantellingen mvantellingen deleted the feat/customer-lowercase-email branch November 21, 2024 18:04
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
mikedebock pushed a commit that referenced this pull request Nov 21, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @labdigital/[email protected]

### Minor Changes

- [#248](#248)
[`1530420`](1530420)
Thanks [@gijsmin](https://github.com/gijsmin)! - add missing
addParcelCustomField action to order

- [#252](#252)
[`f40bbea`](f40bbea)
Thanks [@mikedebock](https://github.com/mikedebock)! - Add support for
lowercaseEmail on customers

### Patch Changes

- [#251](#251)
[`f61e38d`](f61e38d)
Thanks [@jsm1t](https://github.com/jsm1t)! - Fix customer not being
allowed to have no stores

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants