feat: fill shippingInfo on setShippingMethod #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The `?? false` part of the expression was never evaluated, but the result was still correct because `!undefined === true`. This commit mainly fixes the TS2869 typescript errors.
We need it in the cart setShippingMethod action
- Ensure shipping method matches cart - Ensure shipping rate matches cart - Use correct shipping rate tier for determining price when applicable - Improve error handling & reporting
This got accidentally overwritten during a git merge conflict. Restoring them to reduce noise in the diff
mickdekkers
changed the title
okkevandereijk
approved these changes
Oct 16, 2024
mickdekkers
commented
Oct 16, 2024
mickdekkers
added a commit
to mickdekkers/commercetools-node-mock
that referenced
this pull request
Oct 16, 2024
okkevandereijk
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having some trouble writing tests around a shipping method because
cart.shippingInfo.taxedPricewasn't populated by the mocking library. This PR aims to fix that.Status
Currently looking for feedback, particularly on the unresolved questions below. A couple t's left to cross and i's left to dot, but so far the newly written tests pass and it works as expected when testing locally (symlinked) in our project.
Will also add a changeset.
Questions
There's a couple remaining questions around edge cases:
zone.locationfield's docs answers this, can anyone confirm?getShippingMethodsMatchingCartprocesses it, so[0]is correctcart.shippingInfo.priceshould be the net or gross price.