-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(products/search): add storefront search route / mock-functionality #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ols-node-mock into feat/add-product-search
… -> products/search"
…edSearchResponse, with results: ProductSearchResult[].
…24, resulting in results for product search pagination test. upped to 88 to resolve.
…productProjectionParameters are not part of the query.
🦋 Changeset detectedLatest commit: b185241 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
demeyerthom
requested changes
Aug 26, 2024
…type guard) for query expressions given to search.
borisvankatwijk
requested review from
demeyerthom and
mikedebock
and removed request for
mvantellingen
August 27, 2024 07:53
demeyerthom
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
borisvankatwijk
pushed a commit
that referenced
this pull request
Aug 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @labdigital/[email protected] ### Minor Changes - [#209](#209) [`2b74155`](2b74155) Thanks [@borisvankatwijk](https://github.com/borisvankatwijk)! - Addition of "products/search" POST endpoint. Also known as "Storefront Search -> Product Search". Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addition of "products/search" POST endpoint. Also known as "Storefront Search -> Product Search".
https://docs.commercetools.com/api/projects/product-search#representations
Search functionality partially supported
Since the purpose of this is to mock a product search result, we have not added facet, wildcard and boosting behaviour.
We feel this would be creating a "search replacement" for CommerceTools, instead of providing a mock to unit test searching product (format).