Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(products/search): add storefront search route / mock-functionality #209

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

borisvankatwijk
Copy link
Contributor

Changes

Addition of "products/search" POST endpoint. Also known as "Storefront Search -> Product Search".
https://docs.commercetools.com/api/projects/product-search#representations

Search functionality partially supported

Since the purpose of this is to mock a product search result, we have not added facet, wildcard and boosting behaviour.
We feel this would be creating a "search replacement" for CommerceTools, instead of providing a mock to unit test searching product (format).

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: b185241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@labdigital/commercetools-mock Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/product-search.ts Show resolved Hide resolved
…type guard) for query expressions given to search.
@borisvankatwijk borisvankatwijk requested review from demeyerthom and mikedebock and removed request for mvantellingen August 27, 2024 07:53
Copy link
Member

@demeyerthom demeyerthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borisvankatwijk borisvankatwijk merged commit 2b74155 into main Aug 28, 2024
11 checks passed
@borisvankatwijk borisvankatwijk deleted the feat/add-product-search branch August 28, 2024 07:15
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
borisvankatwijk pushed a commit that referenced this pull request Aug 28, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @labdigital/[email protected]

### Minor Changes

- [#209](#209)
[`2b74155`](2b74155)
Thanks [@borisvankatwijk](https://github.com/borisvankatwijk)! -
Addition of "products/search" POST endpoint. Also known as "Storefront
Search -> Product Search".

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants