Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

height: 100vh is not limited to the screen, so position: absolute is used instead #42

Merged
merged 1 commit into from
Sep 23, 2023
Merged

height: 100vh is not limited to the screen, so position: absolute is used instead #42

merged 1 commit into from
Sep 23, 2023

Conversation

kurgm
Copy link
Owner

@kurgm kurgm commented Sep 18, 2023

#15 から分割しました (cc @graphemecluster)

height: 100vh はスクリーンの高さとは限らないので代わりに position: absolute を使用

@graphemecluster @kurgm
height: 100vh is not limited to the screen, so position: absolute…
64b847f 
… is used instead

`height: 100vh` はスクリーンの高さとは限らないので代わりに `position: absolute` を使用
@kurgm kurgm mentioned this pull request Sep 18, 2023
Draft
@graphemecluster
Copy link
Collaborator

（ちなみに去年サポートし始めたばかりの 100dvh を使っても行けますが新しすぎてさすがに互換性に問題が生じます）

@graphemecluster
Copy link
Collaborator

なお正しくは「100vh はスクリーンの高さであり viewport の高さではないので特に携帯では 100vh は viewport の高さを超えることがある」でしたね、昔の言い方が雑すぎました

@kurgm kurgm merged commit 694b6ec into master Sep 23, 2023
1 check passed
@kurgm kurgm deleted the avoid-100vh branch September 23, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurgm @graphemecluster