Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken turbo streams response on schedule page. #211

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Fix broken turbo streams response on schedule page. #211

merged 3 commits into from
Dec 24, 2024

Conversation

kinoppyd
Copy link
Member

Background

In #210 , extract ItemsController from PlansController. but copy-and-paste code has broken.

Fix

  • In ItemsController, detect schedule.id from @item variable, not parameter.
  • Restore hidden field params mode on _card partial that does not removable.

@kinoppyd kinoppyd merged commit f96727c into main Dec 24, 2024
2 checks passed
@kinoppyd kinoppyd deleted the fixes/miss_params_on_schedule_item_remove branch December 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kinoppyd