Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farewell smarthr UI, welcome tailwind #114

Merged
merged 58 commits into from
Mar 25, 2024

Conversation

kinoppyd
Copy link
Member

@kinoppyd kinoppyd commented Feb 29, 2024

  • SmartHR UI を削除し、全てTailwindに置き換え
  • TurboFrameに対応
  • E2Eテストの追加
  • JSのバンドラーをesbuildに変更
  • Node を 20.11.1に更新
  • Railsを 7.1.3.2に更新
  • Rubyを 3.3.0に更新

@exSOUL
Copy link
Collaborator

exSOUL commented Mar 1, 2024

Farewell song

@kinoppyd kinoppyd marked this pull request as ready for review March 21, 2024 15:52
@kinoppyd kinoppyd force-pushed the features/farewell_smarthr_ui_welcome_tailwind branch 4 times, most recently from 49017e7 to e415c53 Compare March 21, 2024 16:14
@kinoppyd kinoppyd force-pushed the features/farewell_smarthr_ui_welcome_tailwind branch from e415c53 to d09638f Compare March 21, 2024 16:16
@kinoppyd kinoppyd requested a review from exSOUL March 21, 2024 16:20
@exSOUL
Copy link
Collaborator

exSOUL commented Mar 22, 2024

@kinoppyd 土日にポチポチ触ってみます。なので月曜までにはApproveできるかと

Copy link
Collaborator

@e-ikuta e-ikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます!🙏

Copy link
Collaborator

@exSOUL exSOUL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

起動してポチポチしました。
予定への追加やメモ追加などできたので良さそうです。

@kinoppyd kinoppyd merged commit e3cdb3a into 2024 Mar 25, 2024
2 checks passed
@kinoppyd kinoppyd deleted the features/farewell_smarthr_ui_welcome_tailwind branch March 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants