fix(ci): call chart releaser directly. #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
reviewed
Nov 4, 2024
| echo "Pushing chart $chart_path to ghcr.io" | ||
| chart_name=$(helm show chart ${chart_path} | yq ".name") | ||
| REGISTRY="ghcr.io/$GITHUB_REPOSITORY_OWNER/charts" | ||
| echo "REGISTRY=${REGISTRY}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
this is done inside of a for loop, we're going to add this line multiple times, only the last occurrence is going to be used. Do we really need to do that?
There was a problem hiding this comment.
Thanks, I've missed that! Fixed! :)
Updates the release CI to call Chart releaser directly to allow us more control over the process on how the artifacts are signed and uploaded. Signed-off-by: José Guilherme Vanz <[email protected]>
flavio
approved these changes
Nov 5, 2024
I've tested it in my fork. I'll document my tests later in this PR |
|
@jvanz ship it! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the release CI to call Chart releaser directly to allow us more control over the process on how the artifacts are signed and uploaded.
Fix #574