Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disable release workflow #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Disable release workflow #208

wants to merge 1 commit into from

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
The workflow uses actions that are not allowed.
Temporarily disabling the workflow.

Release note:

None

@akrejcir
chore: Disable release workflow
6519cc2 
The workflow uses actions that are not allowed.
Temporarily disabling the workflow.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 14, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

0xFelix
0xFelix reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we allow the mentioned actions?

@akrejcir
Copy link
Collaborator Author

I'd rather look for alternatives made by github, or reimplement it ourselves. It's more secure.

@0xFelix
Copy link
Member

0xFelix commented Nov 15, 2024

Who decided to prohibit these actions?

@akrejcir
Copy link
Collaborator Author

I don't know. This is the error message: https://github.com/kubevirt/vm-console-proxy/actions/runs/11839285441
It may be some configuration of kubevirt org.

@akrejcir
Copy link
Collaborator Author

Ignore my previous comment. I have probably disabled them in the repo configuration at some point:
https://github.com/kubevirt/vm-console-proxy/settings/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrejcir @kubevirt-bot @0xFelix