Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add renovate config #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add renovate config #167

wants to merge 1 commit into from

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jul 29, 2024

What this PR does / why we need it:
chore: add renovate config

Add renovate configuration, which updates main and release branches. release branches are configure to have only security patches.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 29, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 29, 2024

/hold need to wait until this project is onboarded to renovate

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@ksimon1 ksimon1 force-pushed the onboard-renovate branch from 77c5657 to 40fdec8 Compare July 29, 2024 13:54
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 9, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 9, 2024

@akrejcir can you please review this?

akrejcir
akrejcir reviewed Aug 9, 2024
View reviewed changes
renovate.json
":dependencyDashboard"
],
"$schema":"https://docs.renovatebot.com/renovate-schema.json",
"baseBranches":[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a new stable branch on the release. Can you add it here, and in other places if needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for stable branch you would like only security updates or all updates?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only security updates. It is a release branch, but for multiple releases.

@akrejcir
Copy link
Collaborator

akrejcir commented Aug 12, 2024 •
edited
Loading

Let's wait with this PR until we fix renovate issues in SSP. The PR that it opened is not correct.
kubevirt/ssp-operator#1043

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@akrejcir akrejcir mentioned this pull request Aug 12, 2024
Closed
@ksimon1
chore: add renovate config
e9ce6a3 
Add renovate configuration, which updates main and release branches.
release branches are configure to have only security patches.

Signed-off-by: Karel Simon <[email protected]>
@akrejcir
Copy link
Collaborator

I made mistake in previous comment.
I meant this PR: kubevirt/ssp-operator#1039

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2024
@akrejcir
Copy link
Collaborator

akrejcir commented Nov 13, 2024 •
edited
Loading

Renovate is still not fixed in SSP. Can we close this PR?
We can reopen it in the future.

@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir akrejcir left review comments

@jcanocan jcanocan Awaiting requested review from jcanocan

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksimon1 @kubevirt-bot @akrejcir