-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtctl.sh: add deprecation warning and parent dir fallback #1278
Conversation
We want to remove virtctl.sh in the long run [1], for now we are issuing a deprecation warning. [1]: kubevirt#1277 Signed-off-by: Daniel Hiller <[email protected]>
a9ecdd6
to
709c49e
Compare
Since there might be usages outside kubevirt that source kubevirtci cluster-up folder from kubevirt main repo, we add a fallback that uses the parent directory. Signed-off-by: Daniel Hiller <[email protected]>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override check-provision-k8s-1.29 |
@dhiller: Overrode contexts on behalf of dhiller: check-provision-k8s-1.29, check-provision-k8s-1.30 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dhiller: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
1 similar comment
/retest-required |
[1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ed79dc4 Init CNAO_SKIP_CONFIG envvar](kubevirt/kubevirtci#1297) [ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ed79dc4 Init CNAO_SKIP_CONFIG envvar](kubevirt/kubevirtci#1297) [ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[ed79dc4 Init CNAO_SKIP_CONFIG envvar](kubevirt/kubevirtci#1297) [ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[03aa94e Revert "feat: Bumped calico cni version from v3.18.0 to v3.27.2](https://github.com/kubevirt/kubevirtci/pull/1281)"](https://github.com/kubevirt/kubevirtci/pull/1300) [ed79dc4 Init CNAO_SKIP_CONFIG envvar](kubevirt/kubevirtci#1297) [ec02f99 cnao: Bump to v0.96.0](kubevirt/kubevirtci#1294) [09d7753 fedora: Add tcpdump to tooling image](kubevirt/kubevirtci#1290) [16d40d2 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1288) [e60d15b kind: provider scripts consider KUBEVIRTCI_PATH](kubevirt/kubevirtci#1284) [d5c1f38 feat: Bumped calico cni version from v3.18.0 to v3.27.2](kubevirt/kubevirtci#1281) [cff5071 feat: Bumped local-volume-provisioner container image from 2.3.2 to 2.5.0](kubevirt/kubevirtci#1285) [40b4162 whereabouts: bump to latest release v0.8.0](kubevirt/kubevirtci#1282) [5d47649 use systemd as the cgroup driver for CRI-O and kubelet](kubevirt/kubevirtci#1271) [07a2223 Skip CNAO CR](kubevirt/kubevirtci#1283) [1ce8e5d vgpu: Remove kind-1.27-vgpu cluster provider as no longer needed](kubevirt/kubevirtci#1214) [1a63576 virtctl.sh: add deprecation warning and parent dir fallback](kubevirt/kubevirtci#1278) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
What this PR does / why we need it:
We want to remove virtctl.sh in the long run 1, for now we are issuing a deprecation warning.
Also, since there might be usages outside kubevirt that source kubevirtci
cluster-up folder from kubevirt main repo, we add a fallback that uses
the parent directory.
See #1277
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: