Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vmware-tanzu/velero from 1.14.0 to 1.15.0 #292

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ShellyKa13
Copy link
Contributor

@ShellyKa13 ShellyKa13 commented Nov 7, 2024

Bump upstream cluster to run with velero 1.15

Bumps github.com/vmware-tanzu/velero from 1.14.0 to 1.15.0.


updated-dependencies:

  • dependency-name: github.com/vmware-tanzu/velero dependency-type: direct:production update-type: version-update:semver-patch ...

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Bump github.com/vmware-tanzu/velero from 1.14.0 to 1.15.0

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Nov 7, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from shellyka13. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShellyKa13
Copy link
Contributor Author

Due to velero 1.15 bumping in the go mod the go z version currently there isn't a matching builder to make this bump passed.
I reached out to the velero team and asked to not specify go z stream higher then 0 so that there wont be an issue with the builder version. There is an open PR: vmware-tanzu/velero#8399 once it will be merged I will be able to update this PR accordingly

@kaovilai
Copy link
Contributor

fyi my team's upstream have our own https://github.com/konveyor/builder which we can trigger to get any newer go released.

https://quay.io/repository/konveyor/builder?tab=tags&tag=latest

@ShellyKa13
Copy link
Contributor Author

/retest

Bump upstream cluster to run with velero 1.15

Bumps [github.com/vmware-tanzu/velero](https://github.com/vmware-tanzu/velero) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/vmware-tanzu/velero/releases)
- [Changelog](https://github.com/vmware-tanzu/velero/blob/main/CHANGELOG.md)
- [Commits](vmware-tanzu/[email protected])

---
updated-dependencies:
- dependency-name: github.com/vmware-tanzu/velero
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: Shelly Kagan <[email protected]>
Test fails with logs in the velero pods as:
`failed to list instancetype.kubevirt.io/v1beta1,
Resource=virtualmachineinstancetype: the server could not find the
requested resource`
Until we figure out why I'll quarantine the tests so the others
can pass.

Signed-off-by: Shelly Kagan <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 29, 2024
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Dec 29, 2024
@kubevirt-bot
Copy link

@ShellyKa13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kvp-functional-test a1a52e1 link true /test pull-kvp-functional-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants