Improve the upgrade json patch mechanism #3248
Conversation
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nunnatsa
force-pushed
the
improve-json-patch
branch
2 times, most recently
from
8e97220 to
89beed8
Compare
Pull Request Test Coverage Report for Build 12534164661Details
💛 - Coveralls |
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
improve-json-patch
branch
from
89beed8 to
3803291
Compare
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This tool writes the HyperConverged CR with its default values. flags: --out - the output file name; optional; if not exist, wtite to the standard output --format - the file format; optional; may be "yaml", "json" or "go"; default=yaml --header - the boilareplate text file for the "go" output format; optional; ignored if missing. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
improve-json-patch
branch
from
3803291 to
5dacb98
Compare
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Improve the upgrade json patch by: 1. move it to its own package 2. made some refactoring for better performance 3. move the initialization of the upgradePatch object to boot, instead of in the reconcile loop, in order to fail fast on error 4. To implement 3, add a json string of the HyperConverged CR with default values. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
The CRDRemover type was written to remove the v2v CRDs on upgrade. This is no longer relevant. Even for newer CRD removes, we have a common solution - the json patch mechanism. This PR removes the unused code. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
This API version is very old, and there is no need to remove it anymore. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
improve-json-patch
branch
from
5dacb98 to
4d0e1d1
Compare
|
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Fix the dependencies of the release-notes tool
The tool uses an internal package, with own go.mod file with no good reason. This PR removes this go.mod file, to simplify the release-notes dependencies. Also, did some cosmetic fixes regarding text output, to make the code more clear.
Improve the upgrade json patch by
Remove two old upgrade mechanism:
Reviewer Checklist
Jira Ticket:
Release note: