Remove passt network binding plugin Registration #3212

RamLavi · 2024-12-17T20:14:29Z

What this PR does / why we need it:
Currently HCO registers the passt network binding plugin to the Kubevirt CR.
This is no longer needed, as primary UDN VMs now use a different network binding plugin (managedTap)

This PR is removing the registration, alongside all the env Vars used in order to get the params that were needed for that registration.
It's a manual removal of the PR that initially introduced the passt network binding plugin (#3034)

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

Release note:

NONE

This binding plugin is no longer used for primary UDN VMs solution. Removing this binding registration on Kubevirt CR. Signed-off-by: Ram Lavi <[email protected]>

Signed-off-by: Ram Lavi <[email protected]>

RamLavi · 2024-12-17T20:20:05Z

Hey @nunnatsa
I have a problem with the last commit - I seem to be missing something as make build-manifest is failing:

cat: /home/ralavi/go/src/github.com/kubevirt/hyperconverged-cluster-operator/deploy/olm-catalog/community-kubevirt-hyperconverged/1.14.0/manifests/kubevirt-hyperconverged-operator.v1.14.0.clusterserviceversion.yaml: No such file or directory
+++ catch 1 357
+++ echo 'error 1 on line 357'
+++ exit 255
+ rendered_csv='error 1 on line 357'
++ catch 255 357
++ echo 'error 255 on line 357'
error 255 on line 357
++ exit 255
make: *** [Makefile:56: build-manifests] Error 255

but I'm not sure what the error is pointing at

hco-bot · 2024-12-17T22:43:53Z

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot · 2024-12-17T22:43:58Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-17T22:52:39Z

hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp

kubevirt-bot · 2024-12-17T22:52:43Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp

In response to this:

hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-17T23:10:14Z

hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

kubevirt-bot · 2024-12-17T23:10:17Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws

In response to this:

hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-17T23:25:52Z

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot · 2024-12-17T23:25:55Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nunnatsa · 2024-12-18T05:49:53Z

hack/build-manifests.sh

@@ -354,7 +353,6 @@ ${PROJECT_ROOT}/tools/csv-merger/csv-merger \
  --kubevirt-consoleplugin-image-name="${KUBEVIRT_CONSOLE_PLUGIN_IMAGE}" \
  --kubevirt-consoleproxy-image-name="${KUBEVIRT_CONSOLE_PROXY_IMAGE}" \
  --cli-downloads-image-name="${HCO_DOWNLOADS_IMAGE}" \


Suggested change

--cli-downloads-image-name="${HCO_DOWNLOADS_IMAGE}" \

--cli-downloads-image-name="${HCO_DOWNLOADS_IMAGE}" > "${CSV_DIR}/${OPERATOR_NAME}.v${CSV_VERSION}.${CSV_EXT}"

thanks!!
DONE

RamLavi · 2024-12-18T06:39:17Z

Change: Fix build manifest issue

nunnatsa

/approve

kubevirt-bot · 2024-12-18T06:41:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coveralls · 2024-12-18T06:42:47Z

Pull Request Test Coverage Report for Build 12388291070

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 71.66%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	3	86.14%

Totals
Change from base Build 12387925425:	-0.02%
Covered Lines:	6099
Relevant Lines:	8511

💛 - Coveralls

nunnatsa · 2024-12-18T06:45:28Z

/lgtm cancel

nunnatsa · 2024-12-18T06:51:16Z

tools/csv-merger/csv-merger.go

@@ -97,7 +97,6 @@ var (
 	kvUIPluginImage     = flag.String("kubevirt-consoleplugin-image-name", "", "KubeVirt Console Plugin image")
 	kvUIProxyImage      = flag.String("kubevirt-consoleproxy-image-name", "", "KubeVirt Console Proxy image")
 	kvVirtIOWinImage    = flag.String("kv-virtiowin-image-name", "", "KubeVirt VirtIO Win image")
-	primaryUDNImage     = flag.String("primary-udn-binding-image-name", "", "Primary UDN binding image")


please keep the flag for now, so the tool won't fail. just ignore it (see example in the mtq-csv flag); e.g.

_ = flag.String("primary-udn-binding-image-name", "", "deprecated. This flag is ignored")

nunnatsa · 2024-12-18T06:51:44Z

tools/manifest-templator/manifest-templator.go

@@ -77,7 +77,6 @@ var (
 	hppoVersion             = flag.String("hppo-version", "", "HPP operator version")
 	_                       = flag.String("mtq-version", "", "deprecated. This flag is ignored")
 	aaqVersion              = flag.String("aaq-version", "", "AAQ operator version")
-	primaryUDNImage         = flag.String("primary-udn-binding-image-name", "", "Primary UDN binding image")


Signed-off-by: Ram Lavi <[email protected]>

RamLavi · 2024-12-18T07:26:55Z

Change: keep the flag for now, so the tool won't fail

sonarqubecloud · 2024-12-18T07:26:59Z

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RamLavi · 2024-12-18T08:57:30Z

/hold
We may want to holt pushing this for now.

maiqueb · 2024-12-18T09:15:34Z

/hold We may want to holt pushing this for now.

Yes, I think it is better to hold on this until we GA persistentips.

If this goes in now, it'll disturb our results which will make it harder to get the feature graduated.

openshift-ci · 2024-12-18T10:00:22Z

@RamLavi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-kv-smoke-gcp	`3794124`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure	`3794124`	link	true	`/test hco-e2e-consecutive-operator-sdk-upgrades-azure`
ci/prow/hco-e2e-kv-smoke-azure	`3794124`	link	true	`/test hco-e2e-kv-smoke-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-aws	`48e8d38`	link	true	`/test hco-e2e-upgrade-operator-sdk-aws`
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws	`48e8d38`	link	false	`/test hco-e2e-upgrade-operator-sdk-sno-aws`
ci/prow/hco-e2e-operator-sdk-sno-aws	`48e8d38`	link	false	`/test hco-e2e-operator-sdk-sno-aws`
ci/prow/hco-e2e-operator-sdk-aws	`48e8d38`	link	true	`/test hco-e2e-operator-sdk-aws`
ci/prow/hco-e2e-upgrade-operator-sdk-azure	`48e8d38`	link	true	`/test hco-e2e-upgrade-operator-sdk-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kubevirt-bot · 2024-12-23T15:49:44Z

@RamLavi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-hyperconverged-cluster-operator-e2e-k8s-1.32	`48e8d38`	link	true	`/test pull-hyperconverged-cluster-operator-e2e-k8s-1.32`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kubevirt-bot · 2024-12-23T15:49:53Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RamLavi added 2 commits December 17, 2024 21:28

operands/kubevirt: Remove passt primary UDN Binding plugin Registration

67800c8

This binding plugin is no longer used for primary UDN VMs solution. Removing this binding registration on Kubevirt CR. Signed-off-by: Ram Lavi <[email protected]>

util/cluster: Remove check of PrimaryUDNImageEnvV from hco main()

0d96e43

Signed-off-by: Ram Lavi <[email protected]>

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 17, 2024

kubevirt-bot requested review from nunnatsa and tiraboschi December 17, 2024 20:14

kubevirt-bot added the size/M label Dec 17, 2024

nunnatsa reviewed Dec 18, 2024

View reviewed changes

RamLavi force-pushed the revert_passt branch from 3794124 to 77ffdcd Compare December 18, 2024 06:37

nunnatsa approved these changes Dec 18, 2024

View reviewed changes

kubevirt-bot assigned nunnatsa Dec 18, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

nunnatsa reviewed Dec 18, 2024

View reviewed changes

hco-operator: Remove primary UDN Binding image env var from deployment

48e8d38

Signed-off-by: Ram Lavi <[email protected]>

RamLavi force-pushed the revert_passt branch from 77ffdcd to 48e8d38 Compare December 18, 2024 07:26

nunnatsa approved these changes Dec 18, 2024

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024

RamLavi marked this pull request as draft December 18, 2024 10:01

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove passt network binding plugin Registration #3212

Remove passt network binding plugin Registration #3212

RamLavi commented Dec 17, 2024 •

edited

Loading

RamLavi commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

nunnatsa Dec 18, 2024

RamLavi Dec 18, 2024 •

edited

Loading

RamLavi commented Dec 18, 2024

nunnatsa left a comment

kubevirt-bot commented Dec 18, 2024

coveralls commented Dec 18, 2024 •

edited

Loading

nunnatsa commented Dec 18, 2024

nunnatsa Dec 18, 2024

RamLavi Dec 18, 2024

nunnatsa Dec 18, 2024

RamLavi Dec 18, 2024

RamLavi commented Dec 18, 2024

sonarqubecloud bot commented Dec 18, 2024 •

edited

Loading

RamLavi commented Dec 18, 2024

maiqueb commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

kubevirt-bot commented Dec 23, 2024

kubevirt-bot commented Dec 23, 2024

	--cli-downloads-image-name="${HCO_DOWNLOADS_IMAGE}" \
	--cli-downloads-image-name="${HCO_DOWNLOADS_IMAGE}" > "${CSV_DIR}/${OPERATOR_NAME}.v${CSV_VERSION}.${CSV_EXT}"

Remove passt network binding plugin Registration #3212

Are you sure you want to change the base?

Remove passt network binding plugin Registration #3212

Conversation

RamLavi commented Dec 17, 2024 • edited Loading

RamLavi commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

hco-bot commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

nunnatsa Dec 18, 2024

Choose a reason for hiding this comment

RamLavi Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

RamLavi commented Dec 18, 2024

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 18, 2024

coveralls commented Dec 18, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12388291070

Details

💛 - Coveralls

nunnatsa commented Dec 18, 2024

nunnatsa Dec 18, 2024

Choose a reason for hiding this comment

RamLavi Dec 18, 2024

Choose a reason for hiding this comment

nunnatsa Dec 18, 2024

Choose a reason for hiding this comment

RamLavi Dec 18, 2024

Choose a reason for hiding this comment

RamLavi commented Dec 18, 2024

sonarqubecloud bot commented Dec 18, 2024 • edited Loading

Quality Gate passed

RamLavi commented Dec 18, 2024

maiqueb commented Dec 18, 2024

openshift-ci bot commented Dec 18, 2024

kubevirt-bot commented Dec 23, 2024

kubevirt-bot commented Dec 23, 2024

RamLavi commented Dec 17, 2024 •

edited

Loading

RamLavi Dec 18, 2024 •

edited

Loading

coveralls commented Dec 18, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 18, 2024 •

edited

Loading