Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some gomega errors #2533

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix some gomega errors #2533

merged 1 commit into from
Oct 2, 2023

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Oct 1, 2023 •
edited
Loading

The next version of ginkgolinter will check comparison of value from different types. We have one case like this in our functional test.

In addition, fix several HavelLen(0), change them to BeEmpty(). They all were hidden by a //nolint comment.

Jira Ticket:

None

Release note:

None

@nunnatsa
fix some gomega errors
3de747b 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6370084373

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.234%
Totals Coverage Status
Change from base Build 6301809738: 0.0%
Covered Lines: 5212
Relevant Lines: 6044
💛 - Coveralls

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Oct 1, 2023

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.26-centos9

@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2023

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-hco-bundle
  • /test ci-index-hco-upgrade-operator-sdk-bundle
  • /test hco-e2e-kv-smoke-azure
  • /test hco-e2e-kv-smoke-gcp
  • /test hco-e2e-operator-sdk-aws
  • /test hco-e2e-operator-sdk-azure
  • /test hco-e2e-operator-sdk-gcp
  • /test hco-e2e-upgrade-operator-sdk-aws
  • /test hco-e2e-upgrade-operator-sdk-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-azure
  • /test images
  • /test okd-ci-index-hco-bundle
  • /test okd-ci-index-hco-upgrade-operator-sdk-bundle
  • /test okd-hco-e2e-operator-sdk-aws
  • /test okd-hco-e2e-operator-sdk-gcp
  • /test okd-hco-e2e-upgrade-operator-sdk-aws
  • /test okd-hco-e2e-upgrade-operator-sdk-gcp
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test hco-e2e-operator-sdk-sno-aws
  • /test hco-e2e-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-azure

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-ci-index-hco-bundle
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-ci-index-hco-upgrade-operator-sdk-bundle
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-gcp
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-sno-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-sno-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-sno-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-ci-index-hco-bundle
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-ci-index-hco-upgrade-operator-sdk-bundle
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-hco-e2e-operator-sdk-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-hco-e2e-operator-sdk-gcp
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-hco-e2e-upgrade-operator-sdk-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.26-centos9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Oct 1, 2023

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/okd-hco-e2e-operator-sdk-gcp

In response to this:

okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Oct 1, 2023

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2023

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-azure 3de747b link true /test hco-e2e-upgrade-operator-sdk-azure
ci/prow/hco-e2e-operator-sdk-sno-azure 3de747b link false /test hco-e2e-operator-sdk-sno-azure
ci/prow/hco-e2e-kv-smoke-azure 3de747b link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure 3de747b link true /test hco-e2e-upgrade-prev-operator-sdk-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure 3de747b link false /test hco-e2e-upgrade-prev-operator-sdk-sno-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2023

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@kubevirt-bot kubevirt-bot merged commit 761430f into kubevirt:main Oct 2, 2023
4 checks passed
@nunnatsa nunnatsa deleted the fix-gomega branch October 3, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nunnatsa @coveralls @hco-bot @kubevirt-bot @tiraboschi