Adds notes to Developer Workflow docs #2434
Conversation
kubevirt-bot
added
release-note-none
Pull Request Test Coverage Report for Build 5937379051
💛 - Coveralls |
|
Kudos, SonarCloud Quality Gate passed!
|
|
hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| export HCO_OPERATOR_IMAGE=$IMAGE_REGISTRY/$REGISTRY_NAMESPACE/hyperconverged-cluster-operator:$CONTAINER_TAG | ||
|
|
||
| # Image to be used in CSV manifests | ||
| HCO_OPERATOR_IMAGE=$HCO_OPERATOR_IMAGE CSV_VERSION=$CSV_VERSION make build-manifests |
There was a problem hiding this comment.
I don't think that make bundleRegistry on the next line is still accurate.
Now we have to build the bundle image and then the index image and use the index image for the catalogSource or use operator-sdk run bundle <bundle-image>
There was a problem hiding this comment.
Now we have to build the bundle image and then the index image and use the index image for the catalogSource
Do we have any make target for it? Usually projects initialized with operator-sdk init have the targets bundle and bundle-build that build the index image. It's happening in hack/build-index-image.sh, I think:
$ podman build -t "${BUNDLE_IMAGE_NAME}" -f bundle.Dockerfile --build-arg "VERSION=${CURRENT_VERSION}" .But I don't see it being run through any make target. Should it have a make target or do you suggest I put this podman command here and elaborate?
There was a problem hiding this comment.
Yes, we use hack/build-index-image.sh but we lack a make target calling it.
We need to decide if we want to suggest this path or simply suggest to use operator-sdk run bundle <bundle-image> to keep it simpler.
I'm for the second one.
There was a problem hiding this comment.
I'm for the second one.
Me too. But don't we need to generate the bundle first before being able to run it? So something like: operator-sdk generate bundle and then operator-sdk run bundle <bundle-image>?
There was a problem hiding this comment.
we have our dockerfile as bundle.Dockerfile, is operator-sdk generate bundle correctly picking it up?
if not we should simply recommend to build it first, and then execute with operator-sdk run bundle <bundle-image>
There was a problem hiding this comment.
OK, so I ran the following commands, but I'm getting error at the last step:
$ operator-sdk generate bundle --input-dir deploy/index-image/ --output-dir /tmp/bundle
$ operator-sdk bundle validate /tmp/bundle
$ docker build -f deploy/index-image/bundle.Dockerfile -t $IMAGE_REGISTRY/$REGISTRY_NAMESPACE/hco-index:$CONTAINER_TAG deploy/index-image
$ docker push $IMAGE_REGISTRY/$REGISTRY_NAMESPACE/hco-index:$CONTAINER_TAG deploy/index-image
$ operator-sdk bundle validate $IMAGE_REGISTRY/$REGISTRY_NAMESPACE/hco-index:$CONTAINER_TAG
# error
$ operator-sdk run bundle $IMAGE_REGISTRY/$REGISTRY_NAMESPACE/hco-index:$CONTAINER_TAG
INFO[0011] Creating a File-Based Catalog of the bundle "quay.io/dharmit_rh/hco-index:latest"
INFO[0013] Generated a valid File-Based Catalog
FATA[0013] Failed to run bundle: create catalog: error creating registry pod: error building registry pod definition: configMap error: error updating ConfigMap: error creating ConfigMap: ConfigMap "community-kubevirt-hyperconverged-catalog-configmap-partition-2" is invalid: []: Too long: must have at most 1048576 bytesHave you or @nunnatsa tried this earlier? Do we know if it worked? I'm not 100% sure, but I vaguely remember some discussion around the long name issue.
Signed-off-by: Dharmit Shah <[email protected]>
Signed-off-by: Dharmit Shah <[email protected]>
Signed-off-by: Dharmit Shah <[email protected]>
Signed-off-by: Dharmit Shah <[email protected]>
|
@tiraboschi @nunnatsa this PR's ready for another review. It now uses |
|
okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Similar error elsehwere as well. |
|
/retest |
1 similar comment
|
/retest |
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws, hco-e2e-upgrade-prev-operator-sdk-sno-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dharmit: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dharmit: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws, hco-e2e-upgrade-prev-operator-sdk-sno-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
What this PR does / why we need it:
Reviewer Checklist
Jira Ticket:
Release note: