Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CentOS 7 and CentOS Stream 8 EOL #148

Merged
merged 3 commits into from
Jul 5, 2024
Merged

CentOS 7 and CentOS Stream 8 EOL #148

merged 3 commits into from
Jul 5, 2024

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jul 2, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

CentOS 7 and CentOS Stream 8 containerdisks are no longer maintained by the project

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 2, 2024
@kubevirt-bot kubevirt-bot requested review from 0xFelix and akrejcir July 2, 2024 12:14
0xFelix
0xFelix reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Should we mark them as deprecated on quay too?

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@lyarwood
Copy link
Member Author

lyarwood commented Jul 3, 2024

/approve

Should we mark them as deprecated on quay too?

@0xFelix I guess that would require manually editing the documentation in the repo at this stage right? Would you be okay doing that, adding a deprecation notice and highlighting that the disks will eventually be removed in the future?

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@lyarwood lyarwood force-pushed the centos-7-and-centos-stream-8-eol branch from ca708b1 to 01b544d Compare July 3, 2024 14:25
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@lyarwood lyarwood marked this pull request as ready for review July 3, 2024 14:25
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@kubevirt-bot kubevirt-bot requested a review from 0xFelix July 3, 2024 14:25
@lyarwood
Copy link
Member Author

lyarwood commented Jul 3, 2024

/override pull-containerdisks-pipeline-centos

I'll remove this job in a follow up once this PR lands.

@kubevirt-bot
Copy link
Contributor

@lyarwood: Overrode contexts on behalf of lyarwood: pull-containerdisks-pipeline-centos

In response to this:

/override pull-containerdisks-pipeline-centos

I'll remove this job in a follow up once this PR lands.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyarwood
Copy link
Member Author

lyarwood commented Jul 3, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@0xFelix
Copy link
Member

0xFelix commented Jul 4, 2024

@lyarwood To mark CentOS Stream 8 as deprecated on quay an update to the artifacts description is required because Stream 8 and 9 live in the same quay repository and manual edits would be overridden on the next push.

containerdisks/artifacts/centosstream/centos-stream.go

Line 20 in 5796ff6

const description = `<img src="https://upload.wikimedia.org/wikipedia/commons/thumb/9/9e/CentOS_Graphical_Symbol.svg/64px-CentOS_Graphical_Symbol.svg.png" alt="drawing" height="15"/> Centos Stream Generic Cloud images for KubeVirt.

@lyarwood
Copy link
Member Author

lyarwood commented Jul 4, 2024

@lyarwood To mark CentOS Stream 8 as deprecated on quay an update to the artifacts description is required because Stream 8 and 9 live in the same quay repository and manual edits would be overridden on the next push.

containerdisks/artifacts/centosstream/centos-stream.go

Line 20 in 5796ff6

const description = `<img src="https://upload.wikimedia.org/wikipedia/commons/thumb/9/9e/CentOS_Graphical_Symbol.svg/64px-CentOS_Graphical_Symbol.svg.png" alt="drawing" height="15"/> Centos Stream Generic Cloud images for KubeVirt.

Added aa1e660

@lyarwood
Copy link
Member Author

lyarwood commented Jul 4, 2024

/override pull-containerdisks-pipeline-centos

@kubevirt-bot
Copy link
Contributor

@lyarwood: Overrode contexts on behalf of lyarwood: pull-containerdisks-pipeline-centos

In response to this:

/override pull-containerdisks-pipeline-centos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member

0xFelix commented Jul 4, 2024

@lyarwood Can you open a PR to remove the pull-containerdisks-pipeline-centos before this is merged? Thank you!

lyarwood added a commit to lyarwood/project-infra that referenced this pull request Jul 4, 2024
@lyarwood
containerdisks: Remove centos presubmit
8b2450f 
CentOS 7 is now EOL and no longer sync'd as of
kubevirt/containerdisks#148 so we can now remove
the presubmit.

Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood lyarwood mentioned this pull request Jul 4, 2024
Merged
8 tasks
@lyarwood
Copy link
Member Author

lyarwood commented Jul 4, 2024

@lyarwood Can you open a PR to remove the pull-containerdisks-pipeline-centos before this is merged? Thank you!

kubevirt/project-infra#3507

@0xFelix Done.

0xFelix
0xFelix approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@kubevirt-bot kubevirt-bot merged commit 45418d4 into kubevirt:main Jul 5, 2024
7 checks passed
kubevirt-bot pushed a commit to kubevirt/project-infra that referenced this pull request Jul 5, 2024
@lyarwood
containerdisks: Remove centos presubmit (#3507)
9a7e357 
CentOS 7 is now EOL and no longer sync'd as of
kubevirt/containerdisks#148 so we can now remove
the presubmit.

Signed-off-by: Lee Yarwood <[email protected]>
@0xFelix
Copy link
Member

0xFelix commented Jul 5, 2024

Updated the description on https://quay.io/repository/containerdisks/centos and created #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyarwood @kubevirt-bot @0xFelix