-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux bridge Dockerfile to install Golang based on version in … #1953
base: main
Are you sure you want to change the base?
Conversation
…go.mod Modified Dockerfile to dynamically install the correct Go version based on the version specified in the go.mod file. Signed-off-by: Ashok Pariya <[email protected]>
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
Thanks |
sorry, I did not get this, in this pr go.mod is refers to https://github.com/containernetworking/plugins/blob/7f756b411efc3d3730c707e2cc1f2baf1a66e28c/go.mod#L3 |
I still need to understand deeper, but lets wait with this PR Also note please that we can't use go 1.23 for now |
Okay sure, We can hold off on this PR for now and proceed with a static approach using the v1.5.1 tag, which is compatible with Go 1.22 ?? |
Yes please, |
Okay, Thanks. |
…go.mod
Modified Dockerfile to dynamically install the correct Go version based on the version specified in the go.mod file.
What this PR does / why we need it:
Issue:
The latest tags (e.g., v1.6.1, v1.6.0, etc.) from the containernetworking/plugins GitHub repository require Go version 1.23. However, due to the current configuration in the cluster-network-addons-operator repository, the Dockerfile by default installs Go version 1.22.
Solution:
We need to modify the installation process to dynamically install the Go version based on the version specified in the go.mod file.
If the go.mod file specifies a complete Go version (e.g., major.minor.patch), the exact version will be downloaded and installed.
If the go.mod file specifies only the major and minor version (e.g., major.minor), the latest patch version for that minor version will be downloaded and installed.
Special notes for your reviewer:
Release note: