Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop sig-network badge misreporting as zero failures #65

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

The value of sig-network failures was not being set as it was matching
against the badge filename rather than the badge name.

This resulted in the sig-network badge always appearing with 0 failures

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/cc @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


The value of sig-network failures was not being set as it was matching
 against the badge filename rather than the badge name.

This resulted in the sig-network badge always appearing with 0 failures

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot requested a review from xpivarc August 9, 2024 14:39
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Aug 9, 2024
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve (I don't have rights I think)
I knew it :)

@xpivarc
Copy link
Member

xpivarc commented Aug 9, 2024

/lgtm

Copy link
Member Author

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@brianmcarey brianmcarey merged commit dad9967 into main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants