Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve volumes concept page #49154

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

network-charles
Copy link
Contributor

Description

This PR improves the volumes page by adding an introduction to what a volume is. It also improves the section title so it's comprehensible for beginners.

Issue

This PR addresses the below comment in issue #31159.

For beginners with little knowledge of k8, the Volumes should just give a very general picture of managing storage, instead the concept page gives a long list of different type of volumes which most beginners don't really need at this point.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ee21bc9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6767279a48515d0008122973
😎 Deploy Preview https://deploy-preview-49154--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Bannister <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants