-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduling e2e tests: add feature-gate label when these tests depend feature-gate #129105
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Dec 6 04:44:52 UTC 2024. |
/cc @pohly @sanposhiho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 1dd9ea7da9e1b44048fb6ea50d2c8fdf65cc9130
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
@kannon92: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/milestone v1.33 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
It is related to kubernetes/test-infra#32911 which aims to reduce the number of jobs in test-infra when a test only depends on feature-gate.
To achieve it, we also need to change the k/k repo because most tests are not using framework.WithFeatureGate when these tests were written.
Step 1: change the k/k repo to use framework.WithFeatureGate and feature.XXXX in the tests if the tests are depending on feature gates.
Step 2: Once kubernetes/test-infra#32911 is done, we can remove the
feature.XXXX
in some tests. We will do it in a follow-up PR.Which issue(s) this PR fixes:
Ref kubernetes/test-infra#32911
Special notes for your reviewer:
The feature LocalStorageCapacityIsolation is GA since 1.25. https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/.
For kubelet, the feature is controlled by the flag
--local-storage-capacity-isolation
. the default value istrue
.I cannot search the feature label via https://cs.k8s.io/?q=LocalStorageCapacityIsolation&i=nope&files=&excludeFiles=&repos=kubernetes/test-infra.
So, I remove the feature label from e2e test.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: