-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Add .spec.trafficDistribution
support for controller services
#12571
base: main
Are you sure you want to change the base?
Conversation
Add support for `.spec.trafficDistribution` field in controller service configuration to route traffic to endpoints that are topologically closer to the client. Ref: https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution Signed-off-by: Aofei Sheng <[email protected]>
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aofei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @aofei! |
Hi @aofei. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/triage accepted Could you please extend the existing unit tests? Thank you! |
What this PR does / why we need it:
Add support for
.spec.trafficDistribution
field in controller service configuration to route traffic to endpoints that are topologically closer to the client.Ref: https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: