-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX: Remove unused substitutions module. #12449
base: main
Are you sure you want to change the base?
NGINX: Remove unused substitutions module. #12449
Conversation
Hi @elizabeth-dev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
8fa542a
to
5ba8a71
Compare
5ba8a71
to
3f6510a
Compare
/kind cleanup |
3f6510a
to
16e1364
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elizabeth-dev, rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As part of the migration to NJS and sunsetting of Lua scripts, we can remove the substitutions module, since it appears unused.
Types of changes
Which issue/s this PR fixes
Part of #12383
How Has This Been Tested?
The codebase has been inspected in order to ensure the module isn't used anywhere, and the e2e test suite has been passed.
Checklist: