-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213
base: master
Are you sure you want to change the base?
✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213
Conversation
44da353
to
e4c93b6
Compare
…nt and restart gracefully Signed-off-by: xudong liu <[email protected]>
e4c93b6
to
1cd0e4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline discussed with Xudong and this looks good to me. Perhaps only Remove
event should be handled, since the watched file is a symlink and the link path is changed every time when the file is changed.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 12345lcr, XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Will do more tests to see if watch real files is a better approach for us |
/hold cancel I'd prefer keeping |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #1212Special notes for your reviewer:
Release note: