-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI Cloudprovider fixes and features Backport for 1.30 #7628
base: cluster-autoscaler-release-1.30
Are you sure you want to change the base?
OCI Cloudprovider fixes and features Backport for 1.30 #7628
Conversation
allow CA working even with a wrong oci nodepoolid provided
…dification Modify logic to look for ocid type prefix in OCI cloud provider builder
node-group-auto-discovery support for oci
…ment-hasinstances fix: implement HasInstance() for OCI providers
exclude self-managed nodes from being processed
Avoid making delete api calls for nodes that don't have an instance id
Hi @gvnc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gvnc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This PR includes a bunch of PRs cherry-picked to cluster-autoscaler-release-1.30 branch so that next version would include them.
These were already merged to master branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: