Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for recomputing similar nodegroups #7612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rrangith
Copy link
Contributor

@rrangith rrangith commented Dec 16, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Related to #6926

It was suggested that first I add a test that will ensure that by default the similar nodegroup recomputation works. And then in my other PR I can add a test to ensure that if the SkipSimilarNodeGroupRecomputation field is true, then we will not recompute similar nodegroups

This adds no new functionality, just a test. It is almost identical to the existing test here. My new test just changes the expander strategy so that it returns a best option with no similar nodegroups. This will test to make sure this line correctly recomputes the similar nodegroups

Special notes for your reviewer:

You can hide whitespace changes to make it easier to review

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrangith
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rrangith. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@rrangith rrangith force-pushed the test-recompute-similar-ngs branch from 4896bd8 to bc8d3af Compare December 16, 2024 15:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024
@rrangith rrangith force-pushed the test-recompute-similar-ngs branch from bc8d3af to 137f2b4 Compare December 16, 2024 15:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024
@rrangith rrangith marked this pull request as draft December 16, 2024 15:47
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@rrangith rrangith force-pushed the test-recompute-similar-ngs branch 2 times, most recently from f74f8d5 to 66f7b3e Compare December 16, 2024 21:11
@rrangith rrangith force-pushed the test-recompute-similar-ngs branch from 66f7b3e to 9d44562 Compare December 16, 2024 21:14
@rrangith rrangith marked this pull request as ready for review December 16, 2024 21:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants