-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go used to build VPA to 1.19.5 #5484
Conversation
If we're going to specify the builder images like this, should we include a step to ensure we're using the latest go image version in https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/RELEASE.md, regardless of why we're creating a new release? |
Yes, this sounds like a good idea. |
/retest |
45fa53b
to
84e78b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup
For #5455