Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go used to build VPA to 1.19.5 #5484

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

jbartosik
Copy link
Collaborator

/kind cleanup

For #5455

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kgolab February 7, 2023 12:09
@k8s-ci-robot k8s-ci-robot requested a review from krzysied February 7, 2023 12:09
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2023
@voelzmo
Copy link
Contributor

voelzmo commented Feb 7, 2023

If we're going to specify the builder images like this, should we include a step to ensure we're using the latest go image version in https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/RELEASE.md, regardless of why we're creating a new release?

@jbartosik
Copy link
Collaborator Author

If we're going to specify the builder images like this, should we include a step to ensure we're using the latest go image version in https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/RELEASE.md, regardless of why we're creating a new release?

Yes, this sounds like a good idea.

@jbartosik
Copy link
Collaborator Author

/retest

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 98e319b into kubernetes:master Feb 8, 2023
@jbartosik jbartosik deleted the update-builder-go branch February 22, 2023 09:26
k8s-ci-robot added a commit that referenced this pull request Feb 22, 2023
Cherry pick #5482 and #5484 to VPA release 0.13 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants