🌱 Add flag to reserve memory to the virtual machine memory size

[maximsnezhkov]

What this PR does / why we need it:
Add flag to configure memory reservation at VSphereMachineTemplate level.
Which issue(s) this PR fixes:
Fixes #2468

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: maximsnezhkov / name: Maxim Snezhkov (9cec761)

[k8s-ci-robot]

Welcome @maximsnezhkov!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @maximsnezhkov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[killianmuldoon]

Thanks for the contribution @maximsnezhkov - it would be great to add this to an e2e test so we can ensure it works as expected. Do we know if there's limitations on which environments or versions of VSphere this is available on?

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.50%. Comparing base (a4eef1b) to head (9cec761).
Report is 580 commits behind head on main.

Files	Patch %	Lines
pkg/services/govmomi/vcenter/clone.go	71.42%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2469      +/-   ##
==========================================
- Coverage   63.63%   63.50%   -0.14%     
==========================================
  Files         122      122              
  Lines        8753     8759       +6     
==========================================
- Hits         5570     5562       -8     
- Misses       2773     2783      +10     
- Partials      410      414       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maximsnezhkov]

Thanks for the contribution @maximsnezhkov - it would be great to add this to an e2e test so we can ensure it works as expected. Do we know if there's limitations on which environments or versions of VSphere this is available on?

You're welcome. As I understand it, this functionality has been available for use since at least 2013 (https://frankdenneman.nl/2013/02/21/reserve-all-guest-memory-all-locked/)

[chrischdi]

/retest

[chrischdi]

/retest

[chrischdi]

Suggested change

	MemoryReservationLockedToMax: memLockedToMax,
	MemoryReservationLockedToMax: vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax,

We can directly reference that setting.

[chrischdi]

Suggested change

	var memLockedToMax *bool
	if vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax != nil {
	memLockedToMax = new(bool)
	*memLockedToMax = *vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax
	}

Should not be required when directly referring below

[sbueringer]

@maximsnezhkov Are you still interested in pursuing this PR? (and do you have time to adress the open comments)

[sbueringer]

/close

See above

[k8s-ci-robot]

@sbueringer: Closed this PR.

In response to this:

/close

See above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.