[WIP] Replace last usage of Azure/go-autorest

[mboersma]

/kind cleanup

What this PR does / why we need it:

Replaces the last usages of the deprecated Azure/go-autorest library.

Which issue(s) this PR fixes:

Fixes #2974

Special notes for your reviewer:

This mostly adapts the Environment code from go-autorest that we still seem to be using.

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[codecov]

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (1d29cae) to head (e62dc3b).
Report is 628 commits behind head on main.

Files with missing lines	Patch %	Lines
azure/scope/environments.go	75.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4780      +/-   ##
==========================================
+ Coverage   62.45%   62.47%   +0.02%     
==========================================
  Files         196      197       +1     
  Lines       16180    16196      +16     
==========================================
+ Hits        10105    10119      +14     
- Misses       5335     5336       +1     
- Partials      740      741       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jackfrancis]

tasty

[mboersma]

/retest

[jackfrancis]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1ed3ae7644484a6f2629ca8c0cc1181ce7093c98

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

I'm a little confused about how we were really using this type before if not just to store data. Isn't this a SDKv1 construct, and presumably not usable with SDKv2? Should we be utilizing this instead? https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/[email protected]/cloud

[mboersma]

I am also confused; AFAICT we've just been using this as an environment variable container and I've tried to keep the usages intact so as not to break things, but it may all amount to a no-op honestly.

Let me look more closely at Configuration and see if it's a more functional replacement for this go-autorest code path. Thanks @nojnhuh!

[jackfrancis]

/hold

to address @nojnhuh's comment

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mboersma]

/retitle [WIP] Replace last usage of Azure/go-autorest

[k8s-ci-robot]

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-ci-entrypoint	e62dc3b	link	true	/test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-apiversion-upgrade	e62dc3b	link	true	/test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.