-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update actions upload-artifact & download-artifact to v4. #602
chore: update actions upload-artifact & download-artifact to v4. #602
Conversation
Signed-off-by: Lan Liang <[email protected]>
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Both this PR and these two from dependabot have e2e failures, I haven't looked into it. @liangyuanpeng |
Signed-off-by: Lan Liang <[email protected]>
the first problem is upload-artifact and download-artifact need to update with the same time, it's resoved by the first commit of this PR. The second problem is that the name of the log artifact lacks the k8s version, which leads to the problem of repeatedly uploading artifacts.It's resoved by the second commit. All of CI is green now, tested on my fork repo. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52, liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolve #598 and #597