Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build: parameterize base images. #572

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Docker build: parameterize base images. #572

merged 1 commit into from
Mar 7, 2024

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Feb 27, 2024 •
edited
Loading

Docker build: parameterize base images.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
@jkh52 jkh52 force-pushed the parameterize-base-image branch 3 times, most recently from 7b67290 to dac95d4 Compare February 27, 2024 22:23
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 27, 2024

@liangyuanpeng FYI I didn't originally intend for this PR to fix the e2e CI, but I had to touch the 'docker build' command so there is some overlap with #568.

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 28, 2024

/retest

@jkh52 jkh52 force-pushed the parameterize-base-image branch from dac95d4 to 5beb853 Compare February 28, 2024 04:51
@jkh52 jkh52 force-pushed the parameterize-base-image branch from 5beb853 to e25e744 Compare February 28, 2024 18:47
bsdnet
bsdnet reviewed Feb 28, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@jkh52 jkh52 force-pushed the parameterize-base-image branch from e25e744 to f28e677 Compare March 6, 2024 23:03
@jkh52 jkh52 changed the title Docker build: parameterize BASEIMAGE and RUNNERIMAGE. Docker build: parameterize base images. Mar 6, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 6, 2024

/retest

flake:

--- FAIL: TestClose (0.03s)
    client_test.go:263: tunnel closed

@jkh52 jkh52 force-pushed the parameterize-base-image branch from f28e677 to b51adbf Compare March 7, 2024 00:00
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 7, 2024

In addition, we need to parameterize golang part.
Because different companies may use different golang image.

Just saw this suggestion. Done.

liangyuanpeng
liangyuanpeng approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It's time for us to take a step forward.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52, liangyuanpeng, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng liangyuanpeng mentioned this pull request Mar 7, 2024
Closed
tallclair
tallclair reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
For nit, feel free to unhold if you want

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@jkh52 jkh52 force-pushed the parameterize-base-image branch from b51adbf to 9c35214 Compare March 7, 2024 20:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@jkh52
Copy link
Contributor Author

jkh52 commented Mar 7, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@jkh52 jkh52 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8ff71dc into kubernetes-sigs:master Mar 7, 2024
10 checks passed
@jkh52 jkh52 mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@jingxu97 jingxu97 jingxu97 left review comments

@bsdnet bsdnet bsdnet left review comments

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

@vinayakankugoyal vinayakankugoyal vinayakankugoyal approved these changes

@elmiko elmiko Awaiting requested review from elmiko

@ipochi ipochi Awaiting requested review from ipochi

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkh52 @k8s-ci-robot @vinayakankugoyal @bsdnet @jingxu97 @liangyuanpeng @tallclair