capacity: replace --capacity-controller-deployment-mode=none #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "none", the empty string now indicates that the feature is off. This is a bit more intuitive. To emphasize the importance of this flag, the parameters in the documentation are order by relevant (most important first).
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
|
/assign @msau42 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
…go_modules/google.golang.org/grpc-1.57.0 Bump google.golang.org/grpc from 1.56.2 to 1.57.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Instead of "none", the empty string now indicates that the feature
is off. This is a bit more intuitive. To emphasize the importance of
this flag, the parameters in the documentation are order by
relevant (most important first).
Which issue(s) this PR fixes:
#450 (review)
Special notes for your reviewer:
The
--helpoutput now looks like this:Does this PR introduce a user-facing change?: