-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option --extra-create-metadata-prefix #1239
base: master
Are you sure you want to change the base?
Add option --extra-create-metadata-prefix #1239
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @nagius! |
Hi @nagius. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nagius The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Please do not close this PR but review it 🙏 ... |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR add the flag
--extra-create-metadata-prefix <string>
to the command line.This flag allows to select PVC annotations starting with and add them as parameter to the create request. This way we can set arbitrary information in a StatefulSet volumeClaimTemplate that will be available to the driver for each associated PV.
Example, with the flag set to
--extra-create-metadata-prefix="csi.my.company.com"
:Both annotations starting with
csi.my.company.com
will be added as parameter to the volume request and can be use by the driver.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: