Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Optimize persistence agent to pass yaml directly to db and minio client #1244

Merged
merged 2 commits into from
May 24, 2023
Merged

feat(backend): Optimize persistence agent to pass yaml directly to db and minio client #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbaebb
optimize persisten agent to pass yaml directly to db and minio client
Tomcli May 22, 2023
0ac53c6
add legacy mode for users to revert back to old kfp behavior
Tomcli May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/Dockerfile.persistenceagent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ RUN go-licenses csv ./backend/src/agent/persistence > /tmp/licenses.csv && \
FROM alpine:3.11
WORKDIR /bin

COPY backend/src/apiserver/config/ /config
COPY --from=builder /bin/persistence_agent /bin/persistence_agent
# Copy licenses and notices.
COPY --from=builder /tmp/licenses.csv /third_party/licenses.csv
Expand All @@ -51,4 +52,7 @@ ENV NUM_WORKERS 2
#CHILDREFERENCESKIND kind of runs to search for the childReferences
ENV CHILDREFERENCES_KINDS ""

CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH} --numWorker ${NUM_WORKERS} --childReferencesKinds ${CHILDREFERENCES_KINDS}
#LEGACY_STATUS_UPDATE legacy status update method to pass update via apiserver
ENV LEGACY_STATUS_UPDATE "false"

CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH} --numWorker=${NUM_WORKERS} --childReferencesKinds=${CHILDREFERENCES_KINDS} --legacyStatusUpdate=${LEGACY_STATUS_UPDATE} --config=/config
Loading