Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Tomcli committed Mar 27, 2024
1 parent c387009 commit bd3811e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion samples/core/loop_output/loop_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
# limitations under the License.

from kfp import compiler, dsl
from typing import List


@dsl.component
def args_generator_op() -> str:
def args_generator_op() -> List[str]:
return '[1.1, 1.2, 1.3]'


Expand Down
3 changes: 1 addition & 2 deletions samples/core/loop_parameter/loop_parameter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from kfp import compiler, dsl
from typing import List


@dsl.component
Expand All @@ -15,7 +14,7 @@ def concat_op(a: str, b: str) -> str:


@dsl.component
def generate_op() -> List[str]:
def generate_op() -> str:
import json
return json.dumps([{'a': i, 'b': i * 10} for i in range(1, 5)])

Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/github/test-dynamic-loop.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [[ ! -d "$C_DIR" ]]; then C_DIR="$PWD"; fi
source "${C_DIR}/test-pipeline.sh"

RESULT=0
run_test_case "dynamic-loop" "samples/core/loop_parameter/loop_parameter.py" "SUCCEEDED" 20 || RESULT=$?
run_test_case "loop_output" "samples/core/loop_output/loop_output.py" "SUCCEEDED" 20 || RESULT=$?

STATUS_MSG=PASSED
if [[ "$RESULT" -ne 0 ]]; then
Expand Down

0 comments on commit bd3811e

Please sign in to comment.