Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rimolive as member #628

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Dec 15, 2023

Refer to #627

Contributed issues:
kubeflow/kfp-tekton#977
kubeflow/kfp-tekton#1378

pytest output:

=============================================================================== test session starts ================================================================================
platform linux -- Python 3.11.6, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/rmartine/Development/github-projects/internal-acls/github-orgs
plugins: forked-1.6.0, cov-3.0.0, xdist-2.5.0
collected 1 item                                                                                                                                                                   

test_org_yaml.py .                                                                                                                                                           [100%]

================================================================================ 1 passed in 0.09s =================================================================================

Copy link

Hi @rimolive. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Dec 15, 2023

/ok-to-test

@Tomcli
Copy link
Member

Tomcli commented Dec 15, 2023

/lgtm
I'm sponsoring @rimolive to be part of the Kubeflow members.

@Tomcli
Copy link
Member

Tomcli commented Dec 15, 2023

/cc @chensun

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, rimolive, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d5e8c4 into kubeflow:master Dec 15, 2023
3 checks passed
@yhwang
Copy link
Member

yhwang commented Dec 15, 2023

thanks @chensun and @rimolive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants