Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo error and added examples for tensorflow and mindspore. #288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed typo error and added examples for tensorflow and mindspore. #288

wants to merge 2 commits into from

Conversation

XinYao1994
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. Correct code typo error in lib/sedna/algorithms/aggregation/aggregation.py code typo #284
  2. Add TensorFlow and Mindspore examples in Federated Learning.
  3. Upgraded yolov5 YML file in Federated Learning examples.

Which issue(s) this PR fixes:

Fixes #284

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2022
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 22, 2022
JoeyHwong-gk
JoeyHwong-gk reviewed Mar 26, 2022
View reviewed changes
examples/federated_learning/surface_defect_detection_pytorch/interface.py Outdated
s3_transmitter = FederatedLearningV2.get_transmitter_from_config()

class SddDataset(Dataset):
def __init__(self, x, y) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit return in init is not required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

lib/sedna/algorithms/aggregation/aggregation.py
@@ -121,7 +121,7 @@ def __init__(self, cut_layer, epsilon=100):

if isinstance(self.parameters["epsilon"], str):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more simple use if isinstance(self.parameters["epsilon"], str) and self.parameters["epsilon"].isdigit():

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be done because writing them in one line will exceed the chars limitation of one python code when running the style check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyHwong-gk JoeyHwong-gk JoeyHwong-gk left review comments

@JimmyYang20 JimmyYang20 Awaiting requested review from JimmyYang20

@llhuii llhuii Awaiting requested review from llhuii

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lib/sedna/algorithms/aggregation/aggregation.py code typo
3 participants
@XinYao1994 @kubeedge-bot @JoeyHwong-gk