resolve comments

Signed-off-by: SK Ali Arman <[email protected]>
kubedb · Dec 17, 2024 · a6338b6 · a6338b6
1 parent 48226e9
commit a6338b6
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 10 deletions.
diff --git a/catalog/kubestash/raw/mysql/mysql-addon.yaml b/catalog/kubestash/raw/mysql/mysql-addon.yaml
@@ -42,7 +42,7 @@ spec:
         required: false
         usage: Arguments to be passed to the dump command.
       - default: "/var/lib/mysql"
-        name: datadir
+        name: dataDir
         required: false
         usage: Arguments to be passed to the dump command.
       - name: databases
@@ -131,7 +131,7 @@ spec:
         required: false
         usage: Arguments to be passed to the dump command.
       - default: "/var/lib/mysql"
-        name: datadir
+        name: dataDir
         required: false
         usage: Arguments to be passed to the dump command.
       - default: "true"

diff --git a/catalog/kubestash/raw/mysql/mysql-backup-function.yaml b/catalog/kubestash/raw/mysql/mysql-backup-function.yaml
@@ -18,4 +18,3 @@ spec:
   - 8.0.3
   - 8.0.21
   image: ghcr.io/kubedb/mysql-restic-plugin:v0.12.0_${DB_VERSION}
----
diff --git a/catalog/kubestash/raw/mysql/mysql-xtrabackup-function.yaml b/catalog/kubestash/raw/mysql/mysql-xtrabackup-function.yaml
@@ -11,12 +11,11 @@ spec:
   - --scratch-dir=${scratchDir:=}
   - --wait-timeout=${waitTimeout:=300}
   - --mysql-args=${args:=}
-  - --data-directory=${datadir:=}
+  - --data-dir=${dataDir:=}
   availableVersions:
   - 2.4.29
   - 8.0.35
   - 8.1.0
   - 8.2.0
   - 8.4.0
   image: ghcr.io/kubedb/xtrabackup-restic-plugin:v0.0.1_${DB_VERSION}
----
diff --git a/catalog/kubestash/raw/mysql/mysql-xtrabackup-restore-function.yaml b/catalog/kubestash/raw/mysql/mysql-xtrabackup-restore-function.yaml
@@ -12,7 +12,7 @@ spec:
   - --scratch-dir=${scratchDir:=}
   - --wait-timeout=${waitTimeout:=300}
   - --mysql-args=${args:=}
-  - --data-directory=${datadir:=}
+  - --data-dir=${dataDir:=}
   availableVersions:
   - 2.4.29
   - 8.0.35

diff --git a/charts/kubedb-kubestash-catalog/templates/mysql/mysql-addon.yaml b/charts/kubedb-kubestash-catalog/templates/mysql/mysql-addon.yaml
@@ -50,7 +50,7 @@ spec:
       required: false
       usage: Arguments to be passed to the dump command.
     - default: /var/lib/mysql
-      name: datadir
+      name: dataDir
       required: false
       usage: Arguments to be passed to the dump command.
     - name: databases
@@ -139,7 +139,7 @@ spec:
       required: false
       usage: Arguments to be passed to the dump command.
     - default: /var/lib/mysql
-      name: datadir
+      name: dataDir
       required: false
       usage: Arguments to be passed to the dump command.
     - default: "true"

diff --git a/charts/kubedb-kubestash-catalog/templates/mysql/mysql-physical-backup.yaml b/charts/kubedb-kubestash-catalog/templates/mysql/mysql-physical-backup.yaml
@@ -19,7 +19,7 @@ spec:
   - --scratch-dir=${scratchDir:=}
   - --wait-timeout=${waitTimeout:={{ .Values.waitTimeout}}}
   - --mysql-args=${args:={{ .Values.mysql.args }}}
-  - --data-directory=${datadir:=}
+  - --data-dir=${dataDir:=}
   availableVersions:
   - 2.4.29
   - 8.0.35

diff --git a/charts/kubedb-kubestash-catalog/templates/mysql/mysql-physical-restore.yaml b/charts/kubedb-kubestash-catalog/templates/mysql/mysql-physical-restore.yaml
@@ -20,7 +20,7 @@ spec:
   - --scratch-dir=${scratchDir:=}
   - --wait-timeout=${waitTimeout:={{ .Values.waitTimeout}}}
   - --mysql-args=${args:={{ .Values.mysql.args }}}
-  - --data-directory=${datadir:=}
+  - --data-dir=${dataDir:=}
   availableVersions:
   - 2.4.29
   - 8.0.35
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,4 +18,3 @@ spec: @@
       - 8.0.3
       - 8.0.21
       image: ghcr.io/kubedb/mysql-restic-plugin:v0.12.0_${DB_VERSION}
-    ---