Bump k8s-openapi for Kubernetes v1_32 support and MSRV
#1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
clux
changed the title
k8s-openapi for Kubernetes v1_32 support
Technically expands our testing range a little bit, but it simplifies our gunk here. Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=====================================
Coverage 75.9% 75.9%
=====================================
Files 84 84
Lines 7612 7612
=====================================
Hits 5771 5771
Misses 1841 1841 |
..nor does it support yaml anchors so back to hacks. Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
brought in by home dep, but it's within our policy. Signed-off-by: clux <[email protected]>
clux
changed the title
k8s-openapi for Kubernetes v1_32 supportk8s-openapi for Kubernetes v1_32 support and MSRV
Signed-off-by: clux <[email protected]>
given change to floating 'earliest' tag. Signed-off-by: clux <[email protected]>
|
Sending this through for a release. Don't want to be out of sync with k8s-openapi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Kubernetes structs and our latest test version to the earliest k8s-openapi supports;
v1_28. Technically breaks our MK8SV policy slightly, as we only have structs up to1.28. Will make a note in the docs.Upgrades MSRV to
1.81.0(2 version behind stable) to fix CI. Red since a patch version of home v0.5.11 released 6 days ago. Follows our best-effort policy.CI Details
Fixes up
just bump-k8sto become an idempotent setter and pin other CI stuff tok8s-openapi/earliestto ease the logic (we have historically bumped +1 each time, but this time k8s-openapi dropped two versions, so can't really rely on it - also the script was super racey anyway).We were usually 1 or 0 versions ahead of k8s-openapi in bumping, but this time it's actually the other way around. Not going to think about it much right now. Maybe we need to revisit the policy.
MSRV error via last red build before msrv fix: https://github.com/kube-rs/kube/actions/runs/12452623215/job/34761812169