Skip to content

Commit

Permalink
i#6938 sched migrate: Reduce rebalance period to better match kernel (D…
Browse files Browse the repository at this point in the history
…ynamoRIO#6990)

It turns out the Linux kernel's maximum rebalance period is 100ms (the
actual value varies dynamically; our simplified scheduler uses a
constant, though). We thus drop our default value from 150ms to 50ms
which should better match real machines. We also make the launcher's
default match the scheduler's default as the launcher's was even higher.

Issue: DynamoRIO#6938
  • Loading branch information
derekbruening authored Sep 19, 2024
1 parent 659c666 commit 513f584
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion clients/drcachesim/common/options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ droption_t<uint64_t> op_sched_migration_threshold_us(
"last ran on a core before it can be migrated to another core.");

droption_t<uint64_t> op_sched_rebalance_period_us(
DROPTION_SCOPE_ALL, "sched_rebalance_period_us", 1500000,
DROPTION_SCOPE_ALL, "sched_rebalance_period_us", 50000,
"Period in microseconds at which core run queues are load-balanced",
"The period in simulated microseconds at which per-core run queues are re-balanced "
"to redistribute load.");
Expand Down
2 changes: 1 addition & 1 deletion clients/drcachesim/scheduler/scheduler.h
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ template <typename RecordType, typename ReaderType> class scheduler_tmpl_t {
* #time_units_per_us to produce a value that is compared to the "cur_time"
* parameter to next_record().
*/
uint64_t rebalance_period_us = 150000;
uint64_t rebalance_period_us = 50000;
};

/**
Expand Down

0 comments on commit 513f584

Please sign in to comment.