Fixing "No Data Available" in GenerateRecommendations API #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue with
generatedRecommendations
API. After the recent changes we were facing issue with errorThere is not enough data available to generate a recommendation
every time.Fixes # (issue)
generatedRecommendations
APIType of change
How has this been tested?
Test Configuration
Checklist 🎯
Additional information
The debug log showed that the
containerData
wasnull
. Upon further debugging, found that metrics were not being fetched because themetricList
was empty. Digging deeper, discovered that directly comparing theexperimentType
using theequals
function was returning false, even for seemingly equivalent values. This issue was resolved by converting theexperimentType
to aString
using.name()
and performing the comparison, which avoids potential pitfalls associated withenum
equality checks.By relying on .name() for comparison, we mitigate issues such as case sensitivity or mismatches caused by runtime discrepancies (e.g., different instances of the same enum under different class loaders). This approach ensures robust and predictable behavior when comparing enum values.