-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timers for bulk api's #1408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics added are:
|
dinogun
reviewed
Dec 6, 2024
src/main/java/com/autotune/analyzer/workerimpl/BulkJobManager.java
Outdated
Show resolved
Hide resolved
dinogun
reviewed
Dec 6, 2024
dinogun
reviewed
Dec 6, 2024
src/main/java/com/autotune/analyzer/workerimpl/BulkJobManager.java
Outdated
Show resolved
Hide resolved
@kusumachalasani Please fix the conflict |
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
Signed-off-by: kusumachalasani <[email protected]>
kusumachalasani
force-pushed
the
bulktimers
branch
from
December 10, 2024 07:53
0763575
to
c3c0c7d
Compare
Done. |
dinogun
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include timers to measure the timetaken for bulk api. This includes to measure the time taken
Fixes # (issue)
Type of change
How has this been tested?
Ran the bulk kruize demos to ensure the metrics are updated as expected. Also, included some manual bulk calls along with demo to ensure the metrics are updated proly with multiple bulk jobs.
Test Configuration
openshift
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here