Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.2 bug fix to master #1392

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Merge 0.2 bug fix to master #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f89705a
Ensure access to the variable is synchronized
msvinaykumar Nov 25, 2024
34cbbd7
Ensure access to the variable is synchronized
msvinaykumar Nov 25, 2024
8beb188
Merge pull request #1390 from msvinaykumar/syncBlocIssue
dinogun Nov 26, 2024
20f7cc6
Removed deploy autotune as it is currently not supported
chandrams Nov 26, 2024
9c95474
Merge pull request #1394 from chandrams/remove_autotune_push
dinogun Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions .github/workflows/test-on-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,56 +46,6 @@ jobs:
docker tag autotune_operator:pr_${{ env.PR_NUMBER }} kruize/autotune_operator:pr_${{ env.PR_NUMBER }}
docker push kruize/autotune_operator:pr_${{ env.PR_NUMBER }}

deploy_autotune:
# The type of runner that the job will run on
needs: [build_job, get_pr]

runs-on: ubuntu-20.04

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3
- name: Get PR number
run: |
echo "PR_NUMBER=${{ needs.get_pr.outputs.pr_number }}" >> $GITHUB_ENV
- name: Setup Minikube
uses: manusa/[email protected]
with:
minikube version: 'v1.16.0'
kubernetes version: 'v1.19.2'
- name: Display cluster info
run: |
kubectl cluster-info
kubectl get pods -n kube-system
- name: Install Prometheus on minikube
run: |
echo Install Prometheus on minikube
cd scripts
./prometheus_on_minikube.sh -as
- name: Deploy kruize in experiment mode
run: |
echo Deploy Kruize in experiment mode
echo "PR_NUMBER = ${{ env.PR_NUMBER }}"
./deploy.sh -c minikube -i kruize/autotune_operator:pr_${{ env.PR_NUMBER }}
sleep 20
- name: Capture ffdc logs
if: always()
run: |
./scripts/ffdc.sh -d ${GITHUB_WORKSPACE}
- name: Archive results
if: always()
run: |
cd ${GITHUB_WORKSPACE}
tar cvf autotune_results.tar kruize_*log.txt

- name: Upload results
if: always()
uses: actions/upload-artifact@v3
with:
name: autotune-results
path: ./autotune_results.tar
retention-days: 2

deploy_crc:
# The type of runner that the job will run on
needs: [build_job, get_pr]
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/autotune/analyzer/serviceObjects/BulkJobStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class BulkJobStatus {
private String jobID;
private String status;
private int total_experiments;
private int processed_experiments;
private int processed_experiments; //todo : If the primary operations are increments or simple atomic updates, use AtomicInteger. It is designed for lock-free thread-safe access
@JsonProperty("job_start_time")
private String startTime; // Change to String to store formatted time
@JsonProperty("job_end_time")
Expand Down Expand Up @@ -144,11 +144,11 @@ public void setTotal_experiments(int total_experiments) {
this.total_experiments = total_experiments;
}

public int getProcessed_experiments() {
public synchronized int getProcessed_experiments() {
return processed_experiments;
}

public void setProcessed_experiments(int processed_experiments) {
public synchronized void setProcessed_experiments(int processed_experiments) {
this.processed_experiments = processed_experiments;
}

Expand Down