Merge pull request #954 from bharathappali/fix-long-term-rec-issue

Adds threshold for limit rows
kruize · Sep 18, 2023 · e647565 · e647565
2 parents d5169ca + 50616a1
commit e647565
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/...er/performanceProfiles/PerformanceProfileInterface/ResourceOptimizationOpenshiftImpl.java b/...er/performanceProfiles/PerformanceProfileInterface/ResourceOptimizationOpenshiftImpl.java
@@ -94,26 +94,30 @@ public void generateRecommendation(KruizeObject kruizeObject, List<ExperimentRes
             the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values
         */
         String experiment_name = kruizeObject.getExperimentName();
-        int limitRows = (int) ((
+        int theoriticalLimitRows = (int) ((
                 KruizeConstants.RecommendationEngineConstants.DurationBasedEngine.DurationAmount.LONG_TERM_DURATION_DAYS *
                         KruizeConstants.DateFormats.MINUTES_FOR_DAY)
                 / kruizeObject.getTrial_settings().getMeasurement_durationMinutes_inDouble());
 
+        // Adding a 10% of value to make sure there are enough data points to gather the duration required
+        // Will be deprecated once we extract exact number of rows from DB based on duration in minutes needed for each term
+        int practicalLimitRows = RecommendationUtils.getThreshold(theoriticalLimitRows, 10, true);
+
         if (null != interval_start_time) {
             long diffMilliseconds = interval_end_time.getTime() - interval_start_time.getTime();
             long minutes = diffMilliseconds / (60 * 1000);
             int addToLimitRows = (int) (minutes / kruizeObject.getTrial_settings().getMeasurement_durationMinutes_inDouble());
             LOGGER.debug("add to limit rows set to {}", addToLimitRows);
-            limitRows = limitRows + addToLimitRows;
+            practicalLimitRows = practicalLimitRows + addToLimitRows;
         }
-        LOGGER.debug("Limit rows set to {}", limitRows);
+        LOGGER.debug("Limit rows set to {}", practicalLimitRows);
 
         Map<String, KruizeObject> mainKruizeExperimentMap = new HashMap<>();
         mainKruizeExperimentMap.put(experiment_name, kruizeObject);
         new ExperimentDBService().loadResultsFromDBByName(mainKruizeExperimentMap,
                 experiment_name,
                 interval_end_time,
-                limitRows);
+                practicalLimitRows);
         //TODO: Will be updated once algo is completed
         for (ExperimentResultData experimentResultData : experimentResultDataList) {
             if (null != kruizeObject && null != experimentResultData) {

diff --git a/src/main/java/com/autotune/analyzer/recommendations/utils/RecommendationUtils.java b/src/main/java/com/autotune/analyzer/recommendations/utils/RecommendationUtils.java
@@ -160,4 +160,12 @@ public static RecommendationNotification getNotificationForTermAvailability(Reco
         }
         return recommendationNotification;
     }
+
+    public static int getThreshold(int value, int failoverPercentage, boolean direction) {
+        if (direction) {
+            return Math.round(value + value * (failoverPercentage / 100.0f));
+        } else {
+            return Math.round(value - value * (failoverPercentage / 100.0f));
+        }
+    }
 }