Skip to content

Commit

Permalink
Fix/update Windows CI (#330)
Browse files Browse the repository at this point in the history
* Don't install into hidden folder

The actions/upload-artifacts@v4 ignores hidden folders (unless
explicitly told not to), and there is no need for that.  Instead we
install into a folder outside of the sources.

* Update to setup-php-sdk v0.10 and enable caching

The latter should bring a considerable performance improvement.

* Install to folder inside checkout

The upload action is picky about "relative paths", so we work around.
  • Loading branch information
cmb69 authored Nov 5, 2024
1 parent 8b61354 commit 9489365
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ jobs:
uses: actions/checkout@v4
- name: Setup PHP
id: setup-php
uses: php/setup-php-sdk@v0.9
uses: php/setup-php-sdk@v0.10
with:
version: ${{matrix.version}}
arch: ${{matrix.arch}}
ts: ${{matrix.ts}}
cache: true
- name: Fetch dependencies
run: |
curl -LO https://downloads.php.net/~windows/pecl/deps/pthreads-3.0.0-vs16-${{matrix.arch}}.zip
Expand All @@ -52,20 +53,20 @@ jobs:
run: nmake test TESTS="--show-diff tests"
- name: package
run: |
md .install
copy LICENSE .install
copy README.md .install
md win-install
copy LICENSE win-install
copy README.md win-install
if exist x64 (
if exist x64\Release (set prefix=x64\Release) else set prefix=x64\Release_TS
) else (
if exist Release (set prefix=Release) else set prefix=Release_TS
)
copy %prefix%\php_parallel.dll .install
copy %prefix%\php_parallel.pdb .install
copy ..\deps\COPYING .install\COPYING.PTHREADS
copy ..\deps\bin\* .install
copy %prefix%\php_parallel.dll win-install
copy %prefix%\php_parallel.pdb win-install
copy ..\deps\COPYING win-install\COPYING.PTHREADS
copy ..\deps\bin\* win-install
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: parallel-${{matrix.version}}
path: .install
path: win-install

0 comments on commit 9489365

Please sign in to comment.